Last modified: 2013-01-08 00:14:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34409, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32409 - `map' format ignores `intro', `outro' and `default'?
`map' format ignores `intro', `outro' and `default'?
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticMaps (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-14 19:48 UTC by Van de Bugger
Modified: 2013-01-08 00:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Van de Bugger 2011-11-14 19:48:46 UTC
It seems `map' format ignores `intro', `outro', and `default' parameters. My code was:

{{ #ask: ...
| format = map
| intro = <div class="my_map">
| outro = </div>
| default = No points specified.
}}

If there are some points to show, result HTML code include neither <div class="my_map"> nor </div>. (I think I will request "class" parameter for formatting, but `intro' and `outro' parameters should work for `map' format the same way they work for `ol' and `ul' formats.)

If there are no points to show, I would expect "No points specified" message. Instead of the message I see useless Gulf of Guinea map.
Comment 1 Jeroen De Dauw 2011-11-15 13:29:44 UTC
Right, it should support into outro and default. 

> Instead of the message I see useless Gulf of Guinea map.

The map formats support a forceshow parameter which by default is "on". If you set it to "off", the map will only be shown when there are actual results.
Comment 2 Jeroen De Dauw 2011-11-15 20:56:34 UTC
I looked into how to best adding this  and discovered the list and table formats add these params via SMWQueryPrinter::textDisplayParameters. I'm not sure why this is the case. Why not simply have this behavior for all formats? Until I have an answer to that question, I'm not adding this to SM, as more general support would be nicer. Markus, can you comment on this?
Comment 3 Jeroen De Dauw 2013-01-08 00:14:40 UTC
These parameters are now correctly held into account.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links