Last modified: 2013-12-31 19:18:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34424, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32424 - SF allows multiple file uploads with a single form field
SF allows multiple file uploads with a single form field
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized minor (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-15 02:02 UTC by badon
Modified: 2013-12-31 19:18 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description badon 2011-11-15 02:02:51 UTC
Text from comments on my form:

<!-- After a file is uploaded, it remains possible to click the "Upload file" link again, to repeat the process. Doing so will cause the previous file to be "lost" due to no semantic properties being applied without also clicking "Save page" at the bottom of the form. Unfamiliar users may do this if they do not realize they need to click yet another button at the bottom of the form, after they've already clicked "Upload file" on the MediaWiki file upload lightbox, and perhaps already filled out the form. --><nowiki />

To solver this issue, Semantic Forms should only allow the "Upload file" link to be clicked once by users. After that, hiding it or graying it out would be appropriate, especially if it's possible to detect a successful upload.
Comment 1 Yaron Koren 2011-11-15 02:55:07 UTC
This seems to me no different from other web forms - as far as I know, most web forms that allow for uploading let users keep re-uploading a file. It only makes sense - if a user changes their mind and wants to upload a different file, they should be allowed to.
Comment 2 badon 2011-11-15 05:14:29 UTC
That sounds reasonable, but in those web forms (email, forum attachments, even on bugzilla here), no file is actually uploaded until the form is submitted. Since that process is actually completed, it makes sense to disable further uploads to cause the user to look to the next steps in the process of completing the Semantic Form.

One issue that arises is when images are uploaded but no semantic data is applied to them, is they can be "lost" if they're supposed to be semantically organized and findable. 

Allowing the user to upload a different file is not prevented. They just need to click whatever link brought them to the Semantic Form again. Of course there are other ways too, namely the ordinary MediaWiki upload system. Off the top of my head, I can't think of a situation where an SF single-field upload system would be preferable for repeated use than either the plain upload system, or one of the multi-upload extensions.

What do you think?
Comment 3 Yaron Koren 2011-11-15 14:13:08 UTC
It's preferable for the situation where a user uploads a file for a field, changes their mind and decides to upload a different file.
Comment 4 badon 2011-11-15 17:48:50 UTC
There are other situations that require other preferences, as I have described. 

And, even in your preferred use case, the user wouldn't be uploading a DIFFERENT file, they would be uploading an ADDITIONAL file. The way the upload form field functions now is misleading, and flawed for any use case that requires semantic data to be applied to the file. Your preferable way of functioning is encouraging that problem.
Comment 5 Yaron Koren 2013-12-31 19:18:21 UTC
Setting to "wontfix" - if users want to upload another file, and replace one file with another in a page, they should be allowed to.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links