Last modified: 2012-01-04 09:45:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34441, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32441 - Year filtering on Special:FundraiserStatistics broken
Year filtering on Special:FundraiserStatistics broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ContributionReporting (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: fun-com, fundraising
: 33505 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-16 12:40 UTC by Roan Kattouw
Modified: 2012-01-04 09:45 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for FundraiserStatistics JavaScript (799 bytes, patch)
2011-12-30 04:21 UTC, Joe Benson
Details

Description Roan Kattouw 2011-11-16 12:40:43 UTC
Steps to reproduce:
1. Go to https://wikimediafoundation.org/wiki/Special:FundraiserStatistics
2. Click customize
3. Uncheck 2007-2009. Only 2010 and 2011 are visible, as expected
4. Switch to "Number of contributions" (or any other tab, really)
5. All years are shown. This is unexpected
6. Check 2007-2009. This makes them *disappear*. Now all boxes are checked but only 2010 and 2011 are shown

Seems like the JS handling the checkboxes is seriously flawed re its handling of the multiple tabs.
Comment 1 Joe Benson 2011-12-30 04:21:53 UTC
Created attachment 9781 [details]
Patch for FundraiserStatistics JavaScript

The problem seems to be with jQuery. When you uncheck 2009 in step 3, the script uses jQuery.toggle(), but toggle() isn't toggling the bars for 2009 on every tab, only the current one. I'm guessing that's because the bars in other tabs are already hidden because their parent <div> is hidden so toggle() ignores them. Whether that's a bug or the folks at jQuery call it a "feature" I don't know. The attached patch for extensions/ContributionReporting sets all bars for a given year to display:block or display:none based on the checkbox state. Tried it on my computer, worked fine.
Comment 2 Ryan Kaldari 2011-12-30 19:03:40 UTC
Thanks for the patch! Fixed in r107646.
Comment 3 Peter Gehres 2012-01-04 09:45:39 UTC
*** Bug 33505 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links