Last modified: 2012-06-05 17:35:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34463, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32463 - Hardcoded http://upload.wikimedia.org image URL in UploadWizard feedback module
Hardcoded http://upload.wikimedia.org image URL in UploadWizard feedback module
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://commons.wikimedia.org/wiki/Sp...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-17 19:55 UTC by Brion Vibber
Modified: 2012-06-05 17:35 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2011-11-17 19:55:07 UTC 
Triggers mixed-content mode warnings at https://commons.wikimedia.org/wiki/Special:UploadWizard

in mw.Feedback.js:

$( '<img src="http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif" />' ) 

the image should probably be copied locally into the extension and loaded via CSS with a relative path.
Comment 1 Platonides 2011-11-18 17:46:35 UTC 
There are already other 4 spinners in the extension, and another at phase3/skins/common/images/ajax-loader.gif

Why are so many spinners needed?
Comment 2 Mark Holmquist 2012-05-10 18:19:54 UTC 
This isn't an UploadWizard-specific file; it's loaded from outside of the extension. You can find the relevant file at resources/mediawiki/mediawiki.feedback.js.
Comment 3 Mark Holmquist 2012-05-10 18:22:00 UTC 
....and, in the latest, it appears to have been fixed anyway--it's now loaded from a configuration variable, see resources/mediawiki/mediawiki.feedback.css.
Comment 4 Mark Holmquist 2012-06-05 17:35:05 UTC 
Absent other, recent complaints, closing as fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links