Last modified: 2013-04-22 16:14:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34469, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32469 - file upload error messages don't work sanely
file upload error messages don't work sanely
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 37462
  Show dependency tree / graph
 
Reported: 2011-11-17 22:43 UTC by Mark A. Hershberger
Modified: 2013-04-22 16:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark A. Hershberger 2011-11-17 22:43:49 UTC 
After specifying the name of a deleted file ("jar2.jpg") on my local install I saw: 

  There was a file by this name, "File:Jar.jpg", but it was deleted and you
  can not reupload the file. If your file is different, try renaming it.

So I gave it "jar.jpg" (the file that had been moved to "jar2.jpg" and then deleted) and I saw this text:

  A file with this name exists already.There was a file by this name,
  "File:Jar.jpg", but it was deleted and you can not reupload the file. If
  your file is different, try renaming it.

That is, "A File with this name exists already."  was just added to the beginning of the previous message w/o erasing it.
Comment 1 Jeroen De Dauw 2011-11-17 23:06:14 UTC 
I tried reproducing this and am getting an alert with "please wait, still checking the title for uniqueness..." instead of any error in the UI, after which nothing happens :/
Comment 2 Mark A. Hershberger 2011-11-18 17:44:31 UTC 
Actual sequence of events before comment 0:

1. Uploaded jar.jpg to local wiki with UW.
2. Moved jar.jpg to jar2.jpg and left a redirect.
3. Deleted jar2.jpg.

Let me know if that does not let you reproduce this.
Comment 3 Jeroen De Dauw 2011-11-18 18:23:15 UTC 
I tried again, those 3 steps, then uploading jar.jpg. And again I'm getting "please wait, still checking the title for uniqueness...".

Looks like we got 2 competing bugs here, fighting for the same turf :)
Comment 4 Mark Holmquist 2012-05-14 16:58:50 UTC 
Mark and Jeroen, can I ask you (though it was a long time ago) what browser(s) you used to test this? I have a sneaking suspicion that IE does something to break how UW does validation.
Comment 5 Mark Holmquist 2012-05-14 18:48:11 UTC 
Jeroen, I think this patch might fix your problem, anyway: https://gerrit.wikimedia.org/r/7608

If not, let me know, because I need to figure out what's causing the issue.
Comment 6 Mark A. Hershberger 2012-05-14 20:10:35 UTC 
ping me in another day and I'll look at this.  I don't have time right now.
Comment 7 Mark Holmquist 2012-08-14 16:20:34 UTC 
Mark, I have totally dropped the ball on this one. Can you take a glance at this sometime soon?

(also, updating keyword to be more better)
Comment 8 Mark Holmquist 2012-08-22 18:49:11 UTC 
FWIW, I managed to perform the steps in the original report without issue, so I think we may have gotten a free fix somewhere.
Comment 9 Ryan Kaldari 2012-08-29 00:16:09 UTC 
Fixed in https://gerrit.wikimedia.org/r/#/c/21211/ and some previous change (don't recall the other one).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links