Last modified: 2011-12-01 16:26:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34501, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32501 - [QuestyCaptcha] Help page is broken
[QuestyCaptcha] Help page is broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ConfirmEdit (CAPTCHA extension) (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-19 17:28 UTC by [[kgh]]
Modified: 2011-12-01 16:26 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description [[kgh]] 2011-11-19 17:28:54 UTC
On the talk page recently an issue was posted [1] that apparently did not make it to bugzilla up till now 

When trying to open the help page, the following messages appear:
<pre>
Notice: Undefined property: QuestyCaptcha::$storage in /.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68

Fatal error: Call to a member function cookiesNeeded() on a non-object in /.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68
</pre>

This behaviour may be experienced on MW 1.16, MW 1.17 and MW 1.18 (probably alpha)

Also user Geraschenko posted a patch for it:

<pre>
===================================================================
--- QuestyCaptcha.class.php     (revision 103604)
+++ QuestyCaptcha.class.php     (working copy)
@@ -65,7 +65,7 @@
     global $wgOut;
     $wgOut->setPageTitle( wfMsg( 'captchahelp-title' ) );
     $wgOut->addWikiText( wfMsg( 'questycaptchahelp-text' ) );
-    if ( $this->storage->cookiesNeeded() ) {
+    if ( CaptchaStore::get()->cookiesNeeded() ) {
        $wgOut->addWikiText( wfMsg( 'captchahelp-cookies-needed' ) );
     }
   }
</pre>

Thank you for having a look at this. Cheers 

[1] http://www.mediawiki.org/wiki/Extension_talk:ConfirmEdit#x.5BQuestyCaptcha.5D_Help_page_on_1.18_is_broken_8574
Comment 1 Mark A. Hershberger 2011-12-01 16:26:06 UTC
r104867

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links