Last modified: 2011-11-21 07:40:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34502, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32502 - Move hard coded CSS into RL
Move hard coded CSS into RL
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-19 18:35 UTC by Sam Reed (reedy)
Modified: 2011-11-21 07:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-11-19 18:35:22 UTC
Like bug 27714

The extension builds some css dynamically based on language code

Should be moved into a RL module somehow and moved out of the buildHeadItem...
Comment 1 Roan Kattouw 2011-11-20 17:36:42 UTC
This is impossible, because the CSS is generated based on programming language code, not on human language code. In fact, some of it is actually based on the source code being highlighted. This can't really be bridged to RL in any reasonable way.
Comment 2 Daniel Friesen 2011-11-21 07:40:38 UTC
It might be slightly complex but I don't believe it's impossible.

The stylesheets that GeSHi generates seams to be based on the arguments you pass to the source tag, not on the actual source.

ie: If you have 12 <source> tags with the same lang and the same <source> arguments then they all have the same style.

The real things that $geshi->get_stylesheet seems to depend on is things like the line-numbers setting, etc...

If we write a custom RL module and embed some of the options about the <source> that get loaded like the lang and the other relevant settings into the module name or wherever it is that we need to embed it to get that passed onto the RL module. Then it would be possible to RL-ify those GeSHi styles.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links