Last modified: 2014-02-13 01:16:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34504, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32504 - Allow the "See also" field to accept PHP bugs
Allow the "See also" field to accept PHP bugs
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Andre Klapper
https://bugzilla.mozilla.org/show_bug...
: upstream
Depends on: 49597
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-19 19:44 UTC by Sam Reed (reedy)
Modified: 2014-02-13 01:16 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-11-19 19:44:13 UTC
It's certainly one tracker we use a lot and would be useful

Currently you get:

http://bugs.php.net/bug.php?id=39451 is not a valid URL to a bug. See Also URLs should point to one of:
show_bug.cgi in a Bugzilla installation.
A bug on launchpad.net
An issue on code.google.com.
A bug on bugs.debian.org.

Might be a config thing (can't see anything obvious), or might need an upstream bug...
Comment 1 Brion Vibber 2011-11-20 18:56:23 UTC
Upstream bug in Bugzilla:

https://bugzilla.mozilla.org/show_bug.cgi?id=577847

Might be able to hack in some custom validation, don't know if there's a good interface for it.
Comment 2 Sam Reed (reedy) 2011-11-20 19:15:10 UTC
(In reply to comment #1)
> Might be able to hack in some custom validation, don't know if there's a good
> interface for it.

A quick look suggests it's going to be a case of changing core files :(
Comment 4 Sam Reed (reedy) 2012-03-13 16:53:38 UTC
(In reply to comment #3)
> Here's a patch:
> 
> http://tools.wikimedia.pl/cgi-bin/fossil/timeline?fc&n=20&y=all
> 
> http://tools.wikimedia.pl/cgi-bin/fossil/ci/cf05f0d7bc?sbs=0

Yay for upstreaming them.

I'm not sure whether this is worth making core hacks to put in place till it's committed upstream and available in Bugzilla releases
Comment 5 Marcin Cieślak 2012-03-13 17:12:40 UTC
Thanks! Wouldn't hold my breath. First we will have a discussion whether it needs to go into a bundled extension or core; Then it might be backported to the stable branch and later into what we are running in production. Then wait for the release. 

You know the process, don't you?:)
Comment 6 Sam Reed (reedy) 2012-03-13 17:18:04 UTC
(In reply to comment #5)
> You know the process, don't you?:)

Have you tried getting stuff enabled on Wikipedia? ;)


An extension would be fine, but when I looked at it before, there was no way to modify the list, so there'd have to be some core hacking at a minimum..
Comment 7 Thehelpfulone 2012-06-22 19:21:44 UTC
Reset assignee per bug 37789
Comment 8 Marcin Cieślak 2013-01-16 18:27:19 UTC
as https://bugzilla.mozilla.org/show_bug.cgi?id=735196 has been fixed and we are now upgraded Bugzilla, so maybe this feature is already available for us?
Comment 9 Andre Klapper 2013-01-17 10:15:54 UTC
(In reply to comment #8)
> maybe this feature is already available for us?

Upstream TM is set to v4.4, we run 4.2. Backporting should be easy though (volunteers welcome) - wikimedia/bugzilla/modifications in Gerrit.
Comment 10 Marcin Cieślak 2013-01-17 11:18:58 UTC
Pushed Gerrit change #44393

I need to get access to "bugtracker" group to test it, but it should work easily (I had a patch against 4.0 as well)
Comment 11 Andre Klapper 2013-01-18 11:43:46 UTC
http://bzr.mozilla.org/bugzilla/trunk/files/head:/extensions/MoreBugUrl/

Side-effect: Support for RT URLs.
Comment 12 Daniel Zahn 2013-01-26 00:45:08 UTC
uhm..yeah. I merged that code in Gerrit. Then i pushed it on the server and put it in /srv/org/wikimedia/bugzilla/extensions/MoreBugUrl alongside other extensions and let www-data read stuff. But that is it so far.
Comment 13 Andre Klapper 2013-04-25 10:05:19 UTC
(In reply to comment #12)
> uhm..yeah. I merged that code in Gerrit. Then i pushed it on the server and
> put
> it in /srv/org/wikimedia/bugzilla/extensions/MoreBugUrl alongside other
> extensions and let www-data read stuff. But that is it so far.

I'm confused (and forgot about this ticket, as MoreBugUrl would also support RT links in the "SeeAlso" field which we've patched into Wikimedia Bugzilla in the meantime).
As we have deployed other patches in the meantime and hence have run checksetup.pl, what exactly is left to do here?
Comment 14 Daniel Zahn 2013-04-26 00:56:12 UTC
eh, i also forgot about this one meanwhile. I guess what is left to do here is to just check if it accepts PHP bugs now. In case it doesn't, let's have a new patch set. But i think it's simply done, because i see those files on the server:

root@kaulen:/srv/org/wikimedia/bugzilla/extensions/MoreBugUrl/lib# ls
GetSatisfaction.pm  PHP.pm  ReviewBoard.pm  Rietveld.pm  RT.pm
Comment 15 Andre Klapper 2013-04-26 09:28:13 UTC
Tried on https://bugzilla.wikimedia.org/show_bug.cgi?id=47431 , output is:
https://bugs.php.net/bug.php?id=63520 is not a valid URL to a bug.
Comment 16 Marcin Cieślak 2013-04-26 10:30:17 UTC
Something is not properly merged I think since the error message does not even mention 	<li>A bug on bugs.php.net.</li>  (see https://gerrit.wikimedia.org/r/#/c/44393/2/bugzilla-4.2/extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl).

This might be caused by the "disabled" file in the extension, see Gerrit change #44393 first comment from Andre.
Comment 17 Andre Klapper 2014-01-16 00:03:21 UTC
This will automatically be fixed once we've upgraded Bugzilla to 4.4 (I tested it already), hence adding dependency.
Comment 18 Andre Klapper 2014-02-13 01:16:38 UTC
PHP bugtracker URLs are supported in "See Also" now that we run Bugzilla 4.4 and its MoreBugUrl extension.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links