Last modified: 2011-11-25 17:36:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34505, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32505 - Incorrect spacing on messages for Special:EditWatchlist/raw results
Incorrect spacing on messages for Special:EditWatchlist/raw results
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.20.x
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-19 21:05 UTC by Brad Jorsch
Modified: 2011-11-25 17:36 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add spaces between watchlistedit-raw-done, watchlistedit-raw-added, and watchlistedit-raw-removed messages. (716 bytes, patch)
2011-11-19 21:05 UTC, Brad Jorsch 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Brad Jorsch 2011-11-19 21:05:25 UTC 
Created attachment 9496 [details]
Add spaces between watchlistedit-raw-done, watchlistedit-raw-added, and watchlistedit-raw-removed messages.

When submitting the raw watchlist edit form, the results page displays the watchlistedit-raw-done, watchlistedit-raw-added, and watchlistedit-raw-removed messages with no spaces in between. This results in display along the lines of "Your watchlist has been updated.1 title was added:", missing a space between the two sentences.

The attached patch will fix the issue. If items were both added and removed, the HTML will contain one unnecessary space before the watchlistedit-raw-removed message, but this does not affect the display of the page in the browser.
Comment 1 Sam Reed (reedy) 2011-11-19 21:07:16 UTC 
Hard coding the spaces feels wrong from a localisation/internationalisation side..
Comment 2 Sam Reed (reedy) 2011-11-19 21:15:06 UTC 
Seems we do it already in core. r103709, thanks!
Comment 3 AlexSm 2011-11-22 03:12:04 UTC 
Same issue with [[MediaWiki:Prefs-help-email]] and [[MediaWiki:Prefs-help-email-others]] in preferences; hope someone will see this note...
Comment 4 Brad Jorsch 2011-11-25 17:36:10 UTC 
(In reply to comment #3)
> Same issue with [[MediaWiki:Prefs-help-email]] and
> [[MediaWiki:Prefs-help-email-others]] in preferences; hope someone will see
> this note...

Should probably be filed as a new bug, but at the moment it seems these help messages have been completely removed since r92924.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links