Last modified: 2011-11-22 18:13:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34556, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32556 - SemanticForms: free text dropped when editing pages
SemanticForms: free text dropped when editing pages
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized critical (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-21 22:27 UTC by Van de Bugger
Modified: 2011-11-22 18:13 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Van de Bugger 2011-11-21 22:27:44 UTC
r103048 "followup r102365: bugfix (free text dropped when editing pages)" has opposite effect on my site: before the fix free text area was populated with the page text; starting from this revision free text area is empty.

I do not know why but at my site `$cur_value' has string type and empty.
Comment 1 Van de Bugger 2011-11-21 22:34:49 UTC
Hmm... It depends either on form or on page content. Two of my forms lose free text ($cur_value is empty string), but one form works good ($cur_value is null).

(It seems using string type comparators === brings a lot of mess. What the profit of replacing == with ===?)
Comment 2 Yaron Koren 2011-11-21 23:14:03 UTC
Hi - wow, that's a serious bug. I believe I fixed it now in SVN, by changing the comparison to look for either blank or null. Thanks for diagnosing the problem.

As to why '==' was replaced in the first place - that's a reasonable question. According to Jeroen, who made the original change, '==' doesn't work for certain settings of PHP.
Comment 3 Van de Bugger 2011-11-22 18:13:53 UTC
Thanks, now it works. Verified on r103930.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links