Last modified: 2011-11-22 21:56:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34582, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32582 - Link to toggle TOC is missing in IE 8
Link to toggle TOC is missing in IE 8
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.18.x
All All
: Normal major (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-22 09:37 UTC by Michael M.
Modified: 2011-11-22 21:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Confirmed fix! (111.74 KB, image/png)
2011-11-22 21:56 UTC, Brion Vibber 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Michael M. 2011-11-22 09:37:14 UTC 
Since yesterday the link to toggle the table of contents is missing in Internet Explorer 8. No Javascript errors are shown, but I can confirm in IE's console that

$('<a href="#">').lenght === 0

but

$('<a href="#" />').lenght === 1

So for some reason the link is not created any more by the code in mediawiki.util.js.
Comment 1 Brion Vibber 2011-11-22 21:37:06 UTC 
In current trunk, mediawiki.util.js's TOC setup has:

  $tocToggleLink = $( '<a href="#" class="internal" id="togglelink"></a>' )

which should be fine.

1.18 has it without the close tag:

  $tocToggleLink = $( '<a href="#" class="internal" id="togglelink">' )
Comment 2 Brion Vibber 2011-11-22 21:39:19 UTC 
r93364 fixed it on trunk with other misc code cleanup. Will backport that and any other breaking things.
Comment 3 Brion Vibber 2011-11-22 21:47:45 UTC 
Backported as r103961 on REL1_18 and r103962 on 1.18wmf1.
Comment 4 Brion Vibber 2011-11-22 21:56:53 UTC 
Created attachment 9527 [details]
Confirmed fix!

Before deployment of the revision above, the link was missing on this page as viewed in IE 8 / WinXP. Now shows!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links