Last modified: 2011-11-23 17:50:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34595, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32595 - clean up use of abusefilter-private user rights
clean up use of abusefilter-private user rights
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Lowest normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikimedia.org/w/api.php?a...
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-22 21:10 UTC by db [inactive,noenotif]
Modified: 2011-11-23 17:50 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2011-11-22 21:10:18 UTC
bug 29922 removes the abusefilter-private user rights from $wgAvailableRights.

But you have to clean up the use of that user rights inside CentralAuth. The user right was assigned to the global group sysadmin while removing. It is shown as set when getting the user rights of a user with the api (see url as example).

Maybe other global groups has this right also set. Please remove it from the sysadmins group and check all other groups. The best way is, to enable the user right, remove it from [[meta:Special:GlobalGroupPermissions/sysadmin]] (which produce a log entry for transparent) and then disable it again.

Another way is to check in CentralAuth against $wgAvailableRights before giving the rights back or do permissions check. If that is better, move this bug to CentralAuth (or create/clone a new bug).

Thanks.
Comment 1 Sam Reed (reedy) 2011-11-22 21:25:36 UTC
I've deleted it from the CA database, and also tidied up the abuse filter config slightly

No other global groups have it set

mysql> select * from global_group_permissions where ggp_permission = 'abusefilter-private';
+-----------+---------------------+
| ggp_group | ggp_permission      |
+-----------+---------------------+
| sysadmin  | abusefilter-private |
+-----------+---------------------+
1 row in set (0.01 sec)


mysql> DELETE FROM global_group_permissions where ggp_permission = 'abusefilter-private';
Query OK, 1 row affected (0.01 sec)

mysql> select * from global_group_permissions where ggp_permission = 'abusefilter-private';
Empty set (0.00 sec)
Comment 2 db [inactive,noenotif] 2011-11-23 17:50:49 UTC
The api result looks now ok. All caches should have now the right values.

Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links