Last modified: 2011-11-25 06:32:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34605, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32605 - RSS extension doesn't support protocol-relative URLs
RSS extension doesn't support protocol-relative URLs
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
RSS (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-23 12:27 UTC by MZMcBride
Modified: 2011-11-25 06:32 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2011-11-23 12:27:39 UTC
I tried to do "<rss max="6">//blog.wikimedia.org/feed/</rss>" at <https://wikimediafoundation.org/wiki/Template:Blogbox> and it produced the error "Not a valid URL: //blog.wikimedia.org/feed/".

The RSS extension should support protocol-relative URLs, I think?
Comment 1 Brion Vibber 2011-11-23 16:44:31 UTC
Protocol-relative doesn't really have meaning here; the feed is fetched from the server-side code and cached, so would be fetched the same way from:

* web hits to http
* web hits to https
* server-side batch processing

You should either use the http or the https URL.
Comment 2 MZMcBride 2011-11-23 19:39:35 UTC
(In reply to comment #1)
> Protocol-relative doesn't really have meaning here; the feed is fetched from
> the server-side code and cached, so would be fetched the same way from:
> 
> * web hits to http
> * web hits to https
> * server-side batch processing
> 
> You should either use the http or the https URL.

I was trying to make the output flexible based on the user's current protocol. Is there no way to do that? Should there be?
Comment 3 Roan Kattouw 2011-11-24 10:06:02 UTC
Does the output of <rss> even include the original URL?
Comment 4 MZMcBride 2011-11-24 14:26:30 UTC
(In reply to comment #3)
> Does the output of <rss> even include the original URL?

I don't know. I tried looking at the code, but I couldn't figure out where the list items were being put together.

If you use an https:// input link, you get https:// output. I think supporting protocol-relative output in the RSS extension for blogs that support https and http is reasonable here.
Comment 5 LordAndrew 2011-11-25 06:32:56 UTC
If // is used as the protocol in the extension tag, we could rewrite URLs returned by the feed to be protocol relative before outputting them. 

But every URL in a feed may not be on  the same domain as the feed. Unless every one of those URLs is on the same domain, we can't be sure they actually support both protocols. If the feed is on a different domain than the content of the feed (such as with Planet Wikimedia, FeedBurner, etc.), the protocols we can use to access that content are a mystery. We can tell from the URL that we can use one of http:// or https://, but we don't know if we can use both unless we check.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links