Last modified: 2011-11-26 19:04:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34632, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32632 - SemanticMaps: Title.
SemanticMaps: Title.
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticMaps (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Jeroen De Dauw
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-24 21:22 UTC by Van de Bugger
Modified: 2011-11-26 19:04 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Let the first data of type `String' be a title. (649 bytes, patch)
2011-11-24 21:24 UTC, Van de Bugger
Details
Atteempt #2. (979 bytes, patch)
2011-11-26 08:48 UTC, Van de Bugger
Details

Description Van de Bugger 2011-11-24 21:22:49 UTC
I use

 {{ #ask: ... 
 | format = map 
 }}

A point on the map has title. Title is shown as a tooltip when mouse cursor hovers the point icon, and also used as title in point's info bubble. There also `#ask' parameter `title' which 

> Allows setting text that will be displayed in the pop-ups of all markers that
> do not have a specific title. 

(taken from http://semantic-mediawiki.org/wiki/Help:Map_format)

However, it is not clear how to set title for a specific point. I did some experiments, then took a look into source code and found that the the first printout statement is taken as point's title, but only it has type `Page'. 

In my application title is not of type `Page' but of type `String'.

Please consider the patch to allow the first printout of `String' type be a title.
Comment 1 Van de Bugger 2011-11-24 21:24:15 UTC
Created attachment 9550 [details]
Let the first data of type `String' be a title.
Comment 2 Van de Bugger 2011-11-26 08:48:41 UTC
Created attachment 9553 [details]
Atteempt #2.

Previous patch causes error in case of KML export.
Comment 3 Van de Bugger 2011-11-26 08:51:06 UTC
BTW, did yo notice a typo in `SM_QueryHandler.php' file:

> /**
> * Make a separate link to the title or not?
> *
> * @since 0.7.3
> *
> * @var boolean
> */
> public $titleLinkSeperate;

Look at name of a variable. Proper spelling is `$titleLinkSeparate'.
Comment 4 Jeroen De Dauw 2011-11-26 16:17:14 UTC
Cool. I modified it a bit, handleResultSubject is only meant to handle actual wiki page results.

r104271
Comment 5 Jeroen De Dauw 2011-11-26 16:17:52 UTC
Oops, just saw I forgot to mention you in the commit - sorry for that.
Comment 6 Van de Bugger 2011-11-26 19:04:18 UTC
Thanks for quick reaction. Verified on r104292.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links