Last modified: 2011-12-08 03:58:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34648, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32648 - Combobox dropdown displays character escape codes in values instead of human-readable characters
Combobox dropdown displays character escape codes in values instead of human-...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-25 23:32 UTC by badon
Modified: 2011-12-08 03:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description badon 2011-11-25 23:32:14 UTC
If a combobox value is something like:

People's Republic of China

it will be displayed as:

People\'s Republic of China

If that value is then selected, and used as a value in the dropdown again later, it will be displayed as:

People\\'s Republic of China

The combobox needs to recognize these character escapes and display them in the correctly interpreted human-readable version, and also avoid repeatedly piling them on with escaping the escapes until we get something that looks like:

People\\\\\\\\\\\\'s Republic of China

This bug may be related to this one:

https://bugzilla.wikimedia.org/show_bug.cgi?id=30042
Comment 1 Yaron Koren 2011-11-27 06:44:16 UTC
This indeed sounds like a serious bug, but I can't reproduce it. Is it visible on a public wiki?
Comment 2 badon 2011-11-28 05:31:29 UTC
Yes, use the login user: Demo pass:test

http://www.coincompendium.com/wiki/index.php/Special:FormEdit/Type/CCT31

Look at the fields for Country and Issuer. If you click the dropdowns, you will see the escape code for the apostrophe. If someone selects the dropdown items, you'll see this:

http://www.coincompendium.com/wiki/index.php/Special:FormEdit/Type/CCT36

Notice on that page that the dropdown list's escapes are accumulating.
Comment 3 Yaron Koren 2011-11-28 05:41:56 UTC
I still don't see the issue. For both of those pages, the form is correctly showing the contents of the page, and when submitted it correctly saves the value from the dropdown.
Comment 4 Yaron Koren 2011-12-06 03:58:53 UTC
Marking this as "worksforme".
Comment 5 badon 2011-12-07 23:49:41 UTC
I made a demo for this bug here:

http://www.coincompendium.com/wiki/index.php/Sandbox/Bug_32648

You can see that the combobox values are being filled with an apostrophe, but it displays it as \' and that's what it puts in the field when it is selected.
Comment 6 Yaron Koren 2011-12-07 23:55:36 UTC
You're using an older version of SF (2.2.1) - try upgrading.
Comment 7 badon 2011-12-08 00:06:20 UTC
Nice, it looks like a new version is out within the last week. I'll upgrade and test to see if the problem goes away, and report back.
Comment 8 badon 2011-12-08 00:17:26 UTC
The upgrade is complete, and the problem is still there. Are you able to reproduce it?
Comment 9 Yaron Koren 2011-12-08 01:01:48 UTC
Ah - the issue was the combination of combobox and "values from property". This
is now fixed in SVN.
Comment 10 badon 2011-12-08 03:30:46 UTC
Thanks for finding that Yaron. Krinkle gave me some advice today about how to strip down a demo to better isolate problems for bug reports. I'm pleased to see it works as he promised.
Comment 11 Yaron Koren 2011-12-08 03:58:13 UTC
Did it involve providing demos that actually demonstrate the bug in question? :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links