Last modified: 2012-12-24 07:56:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34653, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32653 - Maps: Altitude.
Maps: Altitude.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Maps (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-26 09:01 UTC by Van de Bugger
Modified: 2012-12-24 07:56 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Van de Bugger 2011-11-26 09:01:51 UTC
In my application I use `MapsLocation' class. I faced a minor issue: if I have an instance of `MaspLocation' class, there is no way to distinguish where zero altitude was explicitly set or altitude was not set at all, because zero is the default value which is also valid altitude value. Could be the default value of altitude changed to `null', so application can recognize whether altitude was set or not?

Thanks.
Comment 1 Jeroen De Dauw 2011-11-26 15:27:19 UTC
Sure, feel free to modify this (as long as it does not break Maps/SM functionality).

I'd actually like to make more extensive modifications to the coordinate/location handling, since right now it's a bit of a mess. The MapsCoordinateParser class does both formatting and parsing, and the MapsLocation class contains both the coordinates and a bunch of meta-data. It'd be better to have some MapsCoordinates class with parsing and formatting methods (possibly making use of separate parsing and formatting classes), and then a MapsLocation class which contains a MapsCoordinates one and holds the meta data.
Comment 2 Jeroen De Dauw 2011-11-26 15:37:16 UTC
These changes are on the roadmap for 1.1 btw. First need to rel 1.0.5.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links