Last modified: 2013-04-06 01:27:08 UTC
Skin::getCachedNotice() on en.wikiquote returns a link that is first inserted with the text "Your continued donations keep wikiquote running" with "continued donations" intended to be click-able. However the text is not click-able when the string is first displayed. Noticed last night while using my wife's blackberry to look up "O Brother, Where art Thou?" quotes. Reproduced today by using firebug to set a breakpoint on the first line of <https://en.wikiquote.org/w/index.php?title=Special:BannerController&cache=/cn.js&303-4> On the blackberry, the "Your continued donations..." is displayed, but the central notice banner is not. The "continued donations" is not click-able.
switching categories since this could well be in main mw
The "your continued donations" text is inserted with: document.writeln("\x3cdiv id=\"localNotice\" lang=\"en\" dir=\"ltr\"\x3e\x3cdiv style=\"position:absolute; z-index:100; right:100px; top:-0px;\" class=\"metadata\" id=\"donate\"\x3e\n\x3cdiv style=\"text-align:right; font-size:80%\"\x3e\x3ci\x3eYour \x3cb\x3e\x3ca href=\"//wikimediafoundation.org/wiki/Fundraising\" class=\"extiw\" title=\"wikimedia:Fundraising\"\x3econtinued donations\x3c/a\x3e\x3c/b\x3e keep Wikiquote running!\x3c/i\x3e\n\x3c/div\x3e\x3c/div\x3e\n\x3c/div\x3e"); It should be clickable since insertion. The BannerController code you are pointing out affects the id #cn-landingpage-link, which I don't see defined anywhere.
The localNotice HTML id your HTML fragment includes is only found in Skin::getCachedNotice(), which is why I pointed it out. I *think* (but will have to check) that this is put in place before the BannnerController code. The string is coming from https://en.wikiquote.org/wiki/MediaWiki:Anonnotice which is inserte4 with Skin::getSiteNotice()
This is beginning to look like a JS problem in the BB browser. Which doesn't surprise me. Now if I could just find a way to have some sort of JS debugger on the phone. :P
The code that generates that link is not related to Special:BannerController. Anonnotice should probably be rewritten to use jQuery rather than document.writeln(), which can cause problems.
Mark: If you have time, could you tell us if this problem still happens? I don't have a device on which to test this. If the problem does not happen anymore at all, please set the status of this report to RESOLVED > WORKSFORME. Thanks a lot for your help!
Given that the CentralNotice BannerController has been almost completely rewritten since this bug was originally filed and that the SiteNotice that was on wikiquote is no longer there; I vote that we close this as no longer relevant to anything.
Thanks Matt. I'll close this as WORKSFORME.
