Last modified: 2014-06-17 17:03:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34685, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32685 - "context.config.$region.offset() is null" in jquery.suggestions.js while typing in search box
"context.config.$region.offset() is null" in jquery.suggestions.js while typi...
Status: RESOLVED FIXED
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-28 15:26 UTC by Brion Vibber
Modified: 2014-06-17 17:03 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2011-11-28 15:26:34 UTC
Happening on trunk; when typing in the search box, suggestions box pops up but doesn't fill with suggestions.

"context.config.$region.offset() is null" err on line 138 of jquery.suggestions.js
Comment 1 Brion Vibber 2011-11-28 18:10:25 UTC
Turns out this is actually:

* $wgEnableMWSuggest is *not* enabled
* Extension:Vector is being used
* $wgVectorUseSimpleSearch is *not* enabled

so it looks like some of the search code is trying to run when it's not enabled.
Comment 2 Brion Vibber 2011-11-28 18:21:19 UTC
I think this is happening because the 'vector-simplesearch' option was left enabled; Vector.hooks.php seems to indicate that to activate the simplesearch module it's checking for the user settings but *is not* checking whether it's actually enabled... and apparently then the code never checks that its structures are actually present.
Comment 3 Brion Vibber 2011-11-28 18:26:29 UTC
Fixed in r104465: simplesearch now checks if it's actually present on the page before hooking up suggestions to the search box.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links