Last modified: 2011-12-21 19:53:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34710, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32710 - multiline <noinclude> / <includeonly> fails
multiline <noinclude> / <includeonly> fails
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultiBoilerplate (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Robert Leverington
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-29 17:53 UTC by Christian Boltz
Modified: 2011-12-21 19:53 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Boltz 2011-11-29 17:53:36 UTC
Credits for finding this go to an anonymous user on
http://www.mediawiki.org/wiki/Extension_talk:MultiBoilerplate#noinclude_included

MultiBoilerplate fails to match <noinclude> and <includeonly> if the closing tag is not in the same wikitext line.

I can't provide a clean patch because I'm already using a patched version of MultiBoilerplate (see my other bugreports), therefore I'm including a pseudo-patch ;-)

--- MultiBoilerplate.php        (Revision 71216)
+++ MultiBoilerplate.php        (Arbeitskopie)
@@ -140,2 +140,2 @@
-               $content = preg_replace( '#<noinclude>(.*?)</noinclude>#', '', $content );
-               $content = preg_replace( '#<includeonly>(.*?)</includeonly>#', '$1', $content );
+               $content = preg_replace( '#<noinclude>(.*?)</noinclude>#ims', '', $content );
+               $content = preg_replace( '#<includeonly>(.*?)</includeonly>#ims', '$1', $content );

The difference is the additional 'ims' in both search patterns.
Comment 1 Mark A. Hershberger 2011-12-21 19:53:24 UTC
r106972

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links