Last modified: 2011-12-01 13:16:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34720, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32720 - VipsTest: Wrong image height/width
VipsTest: Wrong image height/width
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
VipsScaler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-30 10:07 UTC by Tim Starling
Modified: 2011-12-01 13:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot including firebug (129.87 KB, image/png)
2011-11-30 10:07 UTC, Tim Starling 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2011-11-30 10:07:57 UTC 
Created attachment 9576 [details]
Screenshot including firebug

Special:VipsTest sometimes puts the wrong height and width on the div containing the image. Since the overflow is hidden, the result is not pretty. The size appears to be acquired while the image loads. If you refresh the page, the image is already cached by the browser, and the correct size is used.

See attached screenshot.
Comment 1 Bryan Tong Minh 2011-11-30 10:24:22 UTC 
I suspect this happens if the the images are not yet ready when the ucompare initialization function is called. This is because the $(document).ready() does not guarantee all assets to be loaded. We should hook into $(document).load() instead.
Comment 2 Bryan Tong Minh 2011-11-30 20:12:59 UTC 
Fixed in r104733.
Comment 3 Antoine "hashar" Musso (WMF) 2011-12-01 13:14:08 UTC 
merged in wmf by r104849. Pending deployment.
Comment 4 Antoine "hashar" Musso (WMF) 2011-12-01 13:16:17 UTC 
merged by Tim \o/
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links