Last modified: 2011-11-30 21:31:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34733, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32733 - ApiSandbox seems broken on the cluster
ApiSandbox seems broken on the cluster
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ApiSandbox (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Brion Vibber
:
Depends on: 30774
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-30 20:43 UTC by Sam Reed (reedy)
Modified: 2011-11-30 21:31 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-11-30 20:43:15 UTC
The loading spinner stays and there's a JS error....


Uncaught TypeError: Object 10 has no method 'replace'
html.escape - load.php:150
html.element - load.php:150
UiBuilder.select - load.php:4
UiBuilder.input - load.php:4
UiBuilder.createInputs - load.php:3
UiBuilder - load.php:2
(anonymous function) - load.php:10
isQuery - load.php:10
jQuery.extend._Deferred.deferred.resolveWith - load.php:14
done - load.php:108
jQuery.ajaxTransport.send.callback - load.php:118
Comment 1 Brion Vibber 2011-11-30 21:04:54 UTC
Some attribute vals being passed into mw.html.element() are numbers instead of strings, and mw.html.element() isn't set up to convert things to strings automatically.

As a workaround, should work fine to force all the vals to strings.
Comment 2 Krinkle 2011-11-30 21:11:58 UTC
(In reply to comment #1)
> Some attribute vals being passed into mw.html.element() are numbers instead of
> strings, and mw.html.element() isn't set up to convert things to strings
> automatically.

I've hit this a few times as well, although so far I hit' it before committing, it sure is annoying.
Fixed in trunk, mw.html.element converts booleans and numbers to strings.
Comment 3 Krinkle 2011-11-30 21:14:11 UTC
See bug 30774. Let's backport r96307.
Comment 4 Brion Vibber 2011-11-30 21:18:54 UTC
Hey this is valid, it just depends on 30774. :)
Comment 5 Brion Vibber 2011-11-30 21:19:57 UTC
r96307 & r96310 fix this when backported.
Comment 6 Sam Reed (reedy) 2011-11-30 21:31:15 UTC
Merged to 1.18 in r104753, 1.18wmf1 in r104754 and pushed to site

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links