Last modified: 2011-12-11 04:35:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34751, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32751 - Special:ListGroupRights says sysops can add "Autochecked users" even when $wgFlaggedRevsAutoconfirm is false
Special:ListGroupRights says sysops can add "Autochecked users" even when $wg...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-01 12:54 UTC by Brad Jorsch
Modified: 2011-12-11 04:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2011-12-01 12:54:53 UTC
The group 'autoreview' is only created when $wgFlaggedRevsAutoconfirm is an array; the default is "false". But since r100327 (fixing bug 31441), the 'autoreview' group is unconditionally added to $wgAddGroups['sysop'] and $wgRemoveGroups['sysop'], leading to this nonexistent group being listed on Special:ListGroupRights.

IMO, the best fix would be to make the $wgAddGroups['sysop'] and $wgRemoveGroups['sysop'] entries conditional on $wgFlaggedRevsAutoconfirm.
Comment 1 Aaron Schulz 2011-12-06 05:00:21 UTC
(In reply to comment #0)
> The group 'autoreview' is only created when $wgFlaggedRevsAutoconfirm is an
> array; the default is "false". But since r100327 (fixing bug 31441), the
> 'autoreview' group is unconditionally added to $wgAddGroups['sysop'] and
> $wgRemoveGroups['sysop'], leading to this nonexistent group being listed on
> Special:ListGroupRights.
> 
> IMO, the best fix would be to make the $wgAddGroups['sysop'] and
> $wgRemoveGroups['sysop'] entries conditional on $wgFlaggedRevsAutoconfirm.

That would then override any LocalSettings changes to the contrary, which is worse.

I might makes sense to always define the group, regardless of $wgFlaggedRevsAutoconfirm.
Comment 2 Aaron Schulz 2011-12-11 04:35:57 UTC
Fixed in r105872. The group now exists by default. If wikis don't want it to even be addable/removable, then the add/remove rights config can be set accordingly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links