Last modified: 2011-12-06 22:39:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34786, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32786 - Change in Database api break extensions


Summary:	Change in Database api break extensions

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Database (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Brion Vibber

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-03 21:45 UTC by Solitarius
Modified:	2011-12-06 22:39 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
wrapper function newFromType (849 bytes, application/octet-stream) 2011-12-03 21:45 UTC, Solitarius	Details
patch file (849 bytes, patch) 2011-12-03 21:48 UTC, Solitarius	Details
Add an attachment (proposed patch, testcase, etc.)

Description Solitarius 2011-12-03 21:45:38 UTC

Created attachment 9603 [details]
wrapper function newFromType

The change to the api in revision 90430 break the extension ExternalData and may disturb the extensions Asksql, SQL2Wiki, WikiTrust.

The attached patch create a wrapper function around the new factory() one.

Comment 1 Solitarius 2011-12-03 21:48:22 UTC

Created attachment 9604 [details]
patch file

same as previous attachment

Comment 2 Daniel Friesen 2011-12-03 21:51:10 UTC

r90430 for those of us who like links.

Comment 3 Brion Vibber 2011-12-06 22:12:01 UTC

I can't actually get Asksql to work even with this change in... it gets a Database object, but the actual query ends up failing in some mysterious way.

Comment 4 Brion Vibber 2011-12-06 22:31:44 UTC

Ok, Asksql doesn't work in 1.17 either (which introduced Database::newFromType if I'm reading right). :P :)

Comment 5 Brion Vibber 2011-12-06 22:33:04 UTC

I didn't read the damn docs. Sorry false alarm. ;)

Comment 6 Brion Vibber 2011-12-06 22:39:29 UTC

Applied on trunk in r105372, plus a tweak to convert the 'tableprefix' entry to 'tablePrefix' to match new behavior.

Confirmed works with Asksql extension (which has to be set up correctly -- don't forget to define its custom parameters for the sql username/pass!)

Marking for merge to 1.18 for a 1.18.1.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links