Last modified: 2011-12-04 16:54:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34795, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32795 - Margins (MediaWiki CSS file commonPrint.css)
Margins (MediaWiki CSS file commonPrint.css)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-04 15:18 UTC by Dovi Jacobs
Modified: 2011-12-04 16:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dovi Jacobs 2011-12-04 15:18:59 UTC
The MediaWiki CSS file commonPrint.css (skins/common/commonPrint.css) contains the following CSS rule (lines #161-164):

p, .documentDescription {
    margin: 1em 0 !important;
    line-height: 1.2em;
}

The !important specifier should be removed. It sets paragraph margins to 1em, regardless of the actual styling and layout of the page (in regular mode). Many pages in the Hebrew wikisource make use of special styling/layout of the text, and this rule breaks the style in print mode, makes them effectively unprintable.
Major wikis (i.e., http://en.wikipedia.org/wiki/MediaWiki:Common.js) try to avoid this problem by providing some overloaded rules --
   mw.util.addCSS( '@media print { sup, sub, p, .documentDescription { line-height: normal; }}');
However, due to the !important specifier, subsequent rules cannot alter the original one.
See also https://bugzilla.wikimedia.org/show_bug.cgi?id=17297#c2 .

(Note: I have filed this bug for: http://he.wikisource.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:Fuzzy)
Comment 1 Derk-Jan Hartman 2011-12-04 16:42:17 UTC
The margin issues is fixed in r105116
Comment 2 Dovi Jacobs 2011-12-04 16:54:45 UTC
Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links