Last modified: 2012-06-12 20:01:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34830, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32830 - Undoing reset doesn't work
Undoing reset doesn't work
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WebFonts (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-06 21:06 UTC by Robin Pepermans (SPQRobin)
Modified: 2012-06-12 20:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robin Pepermans (SPQRobin) 2011-12-06 21:06:20 UTC
I can click on "reset" (radio box) so WebFonts is disabled on that particular page view. I cannot undo that, so it remains disabled unless I refresh my page.

It is the case on most if not all browsers (tested on Windows 7), so I thought it was an obvious bug and was already being taken care of, but it's still not fixed, so here is the bug report...
Comment 1 Robin Pepermans (SPQRobin) 2011-12-06 21:09:24 UTC
Seems to be browser/OS-independent, it's also on Linux.
Comment 2 Santhosh Thottingal 2011-12-07 05:45:22 UTC
Sorry, I could not understand it clearly. What do you meant by Undo of reset? For me, it is selecting a font name and it works for me. I can select a font , after resetting in a page.Please elaborate the expected behavior.
Comment 3 Robin Pepermans (SPQRobin) 2011-12-07 19:40:53 UTC
Ah, now I tested it with e.g. Tamil as user language, I see that it gives various fonts as options.
So the bug is only present when you are using a user language (like English) which doesn't have fonts in WebFonts. Then there aren't any font names, so you only have "reset" as a select option. I can click on reset, which disables WebFonts on that page view. I cannot unselect it to enable WebFonts again.

Try it on e.g. https://translatewiki.net/wiki/WebFonts_assessment?uselang=en where the content has various fonts, no matter which interface language you are using.
Comment 4 Santhosh Thottingal 2011-12-09 07:05:20 UTC
If there is only reset option and no other fonts are shown in the menu, imho this is the expected behavior. We show only reset menu since we have applied webfonts on elements with lang attribute, but userlanguage or content language does not have any fonts.  We expect users to refresh the page if they want to view the page again with the webfonts.
Comment 5 Robin Pepermans (SPQRobin) 2011-12-22 15:38:26 UTC
(In reply to comment #4)
> We expect users to refresh the page if they want to view the page again with the webfonts.

I don't agree on that.. It makes much more sense to be able to unselect it. I would make it a checkbox when there is only the reset option.

Please reconsider this bug.
Comment 6 Santhosh Thottingal 2012-06-07 11:04:44 UTC
See https://gerrit.wikimedia.org/r/10553
Comment 7 Robin Pepermans (SPQRobin) 2012-06-12 20:01:32 UTC
Thanks for fixing this! I'm marking it FIXED, it was still marked INVALID.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links