Last modified: 2011-12-11 20:22:50 UTC
Someone added legal code links to the license messages. Example: Creative Commons Attribution ShareAlike 3.0 ([$2 legal code]) I just update the user preferences and upload campaigns code to actually pass the needed url argument and noticed that only some licenses actually have such an argument, while there are a whole bunch more messages that have the "([$2 legal code])" thing, which is now obviously not rendered. You can easily see this on the edit page of an upload campaign.
I don't quite understand this bug. Erik added the "legal code" thing to the messages, and also added a url: property in the config for the links to the licenses. The problem is he didn't add it everywhere that we show the licenses, including - User Prefs - Upload Campaign config So... is this bug just saying that we need to add the link argument in those places?
> is this bug just saying that we need to add the link argument in those places? No, I already did this The issue is that there are a bunch of licences that have the legal code thing in their message but do not have a legal code url in their definition in the config file, thus resulting in "[$2 legal code]" showing up as-is in the UI for these licenses.
Could you give me an example of a license that doesn't have a URL? I'm looking at the config and they all seem to have a URL if the message string demands it.
Created attachment 9633 [details] Screenshot
See attachment
Yeah, but right in UploadWizard.config.php you have stanzas which contain the URL. And that's where the frontend is getting the URL. So why is that different here? For instance, this is CC-BY-SA-3.0 Austria: 'cc-by-sa-3.0-at' => array( 'msg' => 'mwe-upwiz-license-cc-by-sa-3.0-at', 'templates' => array( 'cc-by-sa-3.0-at' ), 'icons' => array( 'cc-by', 'cc-sa' ), 'url' => 'http://creativecommons.org/licenses/by-sa/3.0/at/legalcode' ),
Ok, my bad. Turns out there was some misplaced comfig code that I did not modify to use the legal code arg, and so causing this bug. Fixed in r105457.
You meant r105475 -- comments attached there. Doesn't seem to be fixed.
