Last modified: 2012-02-02 15:06:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34870, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32870 - CSRF in CodeReview ApiRevisionUpdate
CSRF in CodeReview ApiRevisionUpdate
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-08 05:30 UTC by Tim Starling
Modified: 2012-02-02 15:06 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Starling 2011-12-08 05:30:34 UTC 
The ApiRevisionUpdate module in CodeReview does not have any CSRF protection. The code says:

/**
 * Variation of CodeRevisionCommiter for use in the API. Removes the post and token checking from validPost
 * API can/will do the POST checking (and token?)
 */

No, it does not do token checking. ApiBase::needsToken() and ApiBase::getTokenSalt() must be overridden, which they aren't.
Comment 1 Tim Starling 2011-12-08 05:31:12 UTC 
Adding developer to CC list.
Comment 2 Tim Starling 2011-12-08 05:33:46 UTC 
Note that the client code from r95435 will need to be updated, adding Hashar to the CC list for that.
Comment 3 Rob Lanphier 2012-02-02 00:54:17 UTC 
Appears to be reverted
Comment 4 Sam Reed (reedy) 2012-02-02 14:32:30 UTC 
r95435 was reverted, but the original code Tim mentioned the issue with is still there
Comment 5 Sam Reed (reedy) 2012-02-02 15:06:52 UTC 
r110573
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links