Last modified: 2011-12-08 18:05:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34874, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32874 - Bitmap.php uses -define in ImageMagick configuration line which requires ImageMagick 6.5.6-2 but doesn't do a version check
Bitmap.php uses -define in ImageMagick configuration line which requires Imag...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.20.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-08 16:00 UTC by Christian Neubauer
Modified: 2011-12-08 18:05 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Neubauer 2011-12-08 16:00:36 UTC
In Bitmap.php, around line 284, the code adds the -define option that requires ImageMagick 6.5.6-2, but it doesn't check the version of ImageMagick first.  It looks like this:

 // JPEG decoder hint to reduce memory, available since IM 6.5.6-2
 $decoderHint = "-define jpeg:size={$params['physicalDimensions']}";

Later down in the file, it's done correctly like this:

 if ( version_compare( $this->getMagickVersion(), "6.3.5" ) >= 0 ) {
  $animation_post = '-fuzz 5% -layers optimizeTransparency +map';
 }

Since -define is an optional flag here it should be wrapped in a version check as well.
Comment 1 Sam Reed (reedy) 2011-12-08 16:19:35 UTC
r105559, thanks!
Comment 2 Christian Neubauer 2011-12-08 18:05:15 UTC
Thank you!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links