Last modified: 2013-12-23 18:45:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34894, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32894 - Text area fields are too small


Summary:	Text area fields are too small

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ReplaceText (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low trivial (vote)
Target Milestone:	---
Assigned To:	Tony Thomas

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-09 08:17 UTC by badon
Modified:	2013-12-23 18:45 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch to resize the textareas (1.21 KB, patch) 2012-04-26 18:27 UTC, Pranav Ravichandran	Details
Add an attachment (proposed patch, testcase, etc.)

Description badon 2011-12-09 08:17:26 UTC

ReplaceText is very powerful, and can easily replace large blocks of text. Restricting the size of the input fields to only 2 rows and just a few columns is unnecessary. Please give these fields 100% width and, say, 25 or more rows for easy editing of text. This is important due to the risk of overlooking mistakes if all the text is not visible.

Comment 1 badon 2012-01-09 05:34:51 UTC

Downgraded this to "trivial" since it should be very easy to fix, and isn't much of a problem if worked around when text is edited externally and then pasted into the small text boxes.

Comment 2 Pranav Ravichandran 2012-04-26 18:27:38 UTC

Created attachment 10476 [details]
Patch to resize the textareas

Since setting a 100% width causes problems in IE, I've resized the textareas to 125 columns and 25 rows.

Comment 3 Sumana Harihareswara 2012-04-26 19:11:59 UTC

Hi, Pranav.  Please feel free to get developer access

https://www.mediawiki.org/wiki/Developer_access

and put the patch in Git.

Comment 4 Sumana Harihareswara 2012-04-26 19:33:28 UTC

I'm sorry, please disregard my last comment, as this extension is not in Git yet.

Comment 5 Gerrit Notification Bot 2013-12-21 13:52:45 UTC

Change 103101 had a related patch set uploaded by 01tonythomas:
Resized Text area in ReplaceText extension

https://gerrit.wikimedia.org/r/103101

Comment 6 Tony Thomas 2013-12-21 13:53:26 UTC

I have uploaded the patchset in gerrit.

Comment 7 Gerrit Notification Bot 2013-12-21 16:51:23 UTC

Change 103101 merged by jenkins-bot:
Resized Text area in ReplaceText extension

https://gerrit.wikimedia.org/r/103101

Comment 8 Siebrand Mazeland 2013-12-21 16:51:50 UTC

Thanks.

Comment 9 Tony Thomas 2013-12-21 17:48:58 UTC

(In reply to comment #8)
> Thanks.
Thanks Pranav Ravichandran for the edits. I just pushed it ;)

Comment 10 Yaron Koren 2013-12-22 21:34:00 UTC

That change expanded the number of rows from 2 to 25. Isn't 25 a bit much? As far as I know, most of the time it's just a short piece of text in each input.

Comment 11 Tony Thomas 2013-12-23 18:45:06 UTC

hope it looks tidy now : 
https://gerrit.wikimedia.org/r/#/c/103395/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links