Last modified: 2013-01-18 04:18:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34917, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32917 - It's difficult to tap into the search box
It's difficult to tap into the search box
Status: RESOLVED WORKSFORME
Product: Wikipedia App
Classification: Unclassified
Search (Other open bugs)
1.0.0 (Android)
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 32319
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-09 17:28 UTC by Liangent
Modified: 2013-01-18 04:18 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2011-12-09 17:28:49 UTC
I have to do it many times to get it focused. Dunno why.
Comment 1 Tomasz Finc 2011-12-12 10:36:42 UTC
What phone are you using?
Comment 2 Tomasz Finc 2011-12-22 19:22:09 UTC
We fixed a number of issues with the search box not showing a highlight. This should be good now. Please re-open if its still an issue.
Comment 3 Liangent 2011-12-23 02:30:53 UTC
(In reply to comment #2)
> We fixed a number of issues with the search box not showing a highlight. This
> should be good now. Please re-open if its still an issue.

Can you provide an apk somewhere to test?
Comment 4 Yuvi Panda 2011-12-23 02:43:15 UTC
@Liangent: RC3 apk available here (http://dumps.wikimedia.org/android/WikipediaMobile-RC3.apk)

Do subscribe to the WikimediaMobile mailing list, RC announcements (and soon, nightlies!) will be sent out over there.
Comment 5 Liangent 2011-12-23 03:34:18 UTC
Reopen.

The exact behavior in RC3 is, when I tap the search box it gets an orange border but no cursor nor onscreen keyboard is shown. after this if I tap the search button (there is no text to search now) then tap the text box again, the text box gets the orange border and cursor, and a keyboard is shown.
Comment 6 Brion Vibber 2011-12-23 19:18:06 UTC
My 'absolute' branch resolves this by removing the 'position: fixed' floating toolbar and letting it scroll off the page:
https://github.com/brion/Wikipedia/commits/absolute

This lets us drop the event handlers that screw up the focusing, because we don't need them to work around the bug where click events went through to the background elements.

It also provides more screen space for reading, which is a big plus in portrait orientation where a toolbar eats proportionately more screen space.
Comment 7 Brion Vibber 2012-01-06 00:36:44 UTC
We've now moved to a div instead of iframe, which appears to avoid these clickthrough problems.

Can we confirm?
Comment 8 Liangent 2012-01-09 23:05:11 UTC
(In reply to comment #7)
> We've now moved to a div instead of iframe, which appears to avoid these
> clickthrough problems.
> 
> Can we confirm?

Now the first tap can give the box a yellow border and set cursor in it. However the soft keyboard doesn't shown up. I have to tap the box again to use the keyboard.
Comment 9 Liangent 2012-01-09 23:05:39 UTC
in RC4.
Comment 10 Brion Vibber 2012-12-24 23:33:35 UTC
Still problems with this or is it all resolved?
Comment 11 Brion Vibber 2013-01-18 04:18:35 UTC
Assuming this is all resolved.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links