Last modified: 2013-01-07 10:19:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34925, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32925 - Moodbar comments & feedback should make checkuser table entries
Moodbar comments & feedback should make checkuser table entries
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MoodBar (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-09 18:45 UTC by Aaron Schulz
Modified: 2013-01-07 10:19 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aaron Schulz 2011-12-09 18:45:39 UTC
Right now, checkusers cannot see moodbar activity via Special:CheckUser. It would be nice if they could in order to better curtail abuse.

CheckUser could perhaps listen for a hook (e.g. $wgHooks) that provides data when triggered for CheckUser to store. So we could have something like:

wfRunHooks( 'UserLogIPData', array( $context, $data ) );

$context would be an IContextSource and $data would be an array with values for 'namespace','title','actiontext','comment','type','timestamp').
Comment 1 Aaron Schulz 2011-12-09 20:13:59 UTC
CheckUser alone updated in r105702.
Comment 2 Marcin Cieślak 2012-03-11 21:58:22 UTC
As of r113567 both actions get logged properly, seems like "LoggableUserIPData" hook isn't realy necessary.

(różn.) (hist.) . . Dyskusja użytkownika:Saper . . 05:35 . . Saper (dyskusja | edycje | zablokuj) (Odpowiedzi na opinię użytkownika: teraz działa? )
        IP: 2A01:.......   UserAgent/1.0
(3) . . 05:34 . . Saper (dyskusja | edycje | zablokuj) Saper Opinie MoodBar Specjalna:FeedbackDashboard/3 (confused)
        IP: 2A01:.......   UserAgent/1.0


Shall we remove the hook? It's not used anywhere.
Even things like Special:Translate or WikiLove got logged by edit hooks.
Comment 3 Siebrand Mazeland 2013-01-04 16:09:38 UTC
There is still code in CheckUser, and there still was documentation in hooks.txt. I submitted Gerrit change #42275 to remove the entry in hooks.txt.

CheckUser code still needs to be removed.
Comment 4 Marcin Cieślak 2013-01-04 23:23:30 UTC
Gerrit change #42355 submitted to remove the hook from the CheckUser extension.
Comment 5 Siebrand Mazeland 2013-01-07 10:19:24 UTC
All done now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links