Last modified: 2012-02-07 13:26:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34948, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32948 - {{REVISIONID}} and related magic words should not be blank after doing a null edit
{{REVISIONID}} and related magic words should not be blank after doing a null...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.18.x
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-10 13:06 UTC by c1541
Modified: 2012-02-07 13:26 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description c1541 2011-12-10 13:06:18 UTC
First create a page with the following:

* {{REVISIONUSER}}
* {{REVISIONTIMESTAMP}}

Is will show some data.

However, if a null edit is then done on the page, it doesn't show anything as {{REVISIONUSER}} & {{REVISIONTIMESTAMP}} are blank rather than the user & time of the last edit before the null edit.

A purge will then make the correct values be shown.
Comment 1 Liangent 2011-12-14 05:28:18 UTC
Null edit in what way? Does this edit create a new revision?
Comment 2 Umherirrender 2012-01-10 21:07:20 UTC
A null edit is a save without changes (See [[Wikipedia:NULLEDIT]]). That produce no new new revision in the history, but it should not destroy the REVISION* variable.
Comment 3 Umherirrender 2012-01-20 20:33:25 UTC
Under 1.18 all REVISION*-vars are empty. With 1.19 only REVISIONID and REVISIONUSER are empty, but the other REVISION* are using the timestamp of the nulledit and not the Revision timestamp.

Using the api with action=purge&forcelinkupdate= shows the same behaviour as nulledit, but without forcelinkupdate it is all right. This means a LinkUpdate is not setting the right revision timestamp in its parse context.
Comment 4 Alexandre Emsenhuber [IAlex] 2012-01-21 08:00:09 UTC
Fixed in r109679.
Comment 5 Krinkle 2012-02-07 13:24:31 UTC
This is breaking pages with code like this:

> Last updated by {{User|{{REVISIONUSER}}}} on {{#time:r|{{REVISIONTIMESTAMP}}}} ({{purge}}).

Such as:
https://commons.wikimedia.org/wiki/User:Krinkle/Testcase/1
https://commons.wikimedia.org/wiki/Commons:Auto-protected_files/wikipedia/en

It seems to also affect bot-edits. When a bot edits the 2nd page listed above it also results in those magic words being empty.

Assuming this fix also fixes it for bots, can this please be backported to 1.18wmf1 ?
Comment 6 Krinkle 2012-02-07 13:25:52 UTC
Looks like the bot was also doing a null edit sometimes. Fixed :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links