Last modified: 2011-12-12 06:29:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34958, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32958 - SpecialAllMessages: input form doesn't show and remember filter option
SpecialAllMessages: input form doesn't show and remember filter option
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.20.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-10 22:44 UTC by MrBlueSky
Modified: 2011-12-12 06:29 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch against trunk (925 bytes, patch)
2011-12-10 22:44 UTC, MrBlueSky 		Details
Add an attachment (proposed patch, testcase, etc.)

Description MrBlueSky 2011-12-10 22:44:24 UTC 
Created attachment 9655 [details]
Patch against trunk

Goto for example https://en.wikipedia.org/wiki/Special:AllMessages. Next to "Filter by customisation state" no radiobutton is checked. Choose 'modified' or 'unmodified' and click go: again no radiobutton is checked. Clicking go again defaults to showing all messages instead of the selected filter.

This happens in 1.18 and 1.19.

Its because class AllmessagesTablePager uses $this->filter to set the radiobuttons instead of $this->custom.
Comment 1 Brion Vibber 2011-12-12 06:29:19 UTC 
Done slightly differently on trunk in r105853 -- tagging for 1.18, 1.18wmf1 merge. Looks like something probably broke during a refactor and a var didn't get hoisted down to the tablepager class.

Good catch, and thanks for the report & patch!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links