Last modified: 2012-06-19 09:56:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34983, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32983 - Page protection leads to issue in translatable pages
Page protection leads to issue in translatable pages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Niklas Laxström
https://www.mediawiki.org/wiki/Specia...
:
: 36846 (view as bug list)
Depends on: 36588 36846
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-12 11:50 UTC by Siebrand Mazeland
Modified: 2012-06-19 09:56 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2011-12-12 11:50:53 UTC
Observed on Meta-wiki's [[Terms of use]] page. After the page was protected, PT no longer saw the page as being a translatable page, and the to be translated version could not be updated until an actual content change was made in the page. On Special:PageTranslation it was shown in a seperate section, with only options to delete the translateble page. It did not appear to impact the possibility to translate the page.

Step to reproduce (most probably):
1. create a translatable page and mark it for translation on Special:PageTranslation
2. protect the page
3. observe Special:PageTranslation. This will show the detailed unexpected behaviour.

Expected behaviour: page protection should now disrupt the "marking a revision for translation" on Special:PageTranslation.
Comment 1 Niklas Laxström 2011-12-12 14:38:27 UTC
Without investigating here is my theory: protecting a page makes a new revision in the page history. Since it is not an edit action the onPageSave hooks are not executed, and Translate does not see any info about this new revision, and thus thinks it is not a translatable page.
Comment 2 Siebrand Mazeland 2012-01-18 14:40:30 UTC
https://www.mediawiki.org/wiki/Special:PageTranslation now contains an example. "User:Nemo bis/Fréttinga" is classified in "Broken pages" but the only thing that happened is that the page was protected.
Comment 3 Niklas Laxström 2012-05-08 07:58:19 UTC
https://gerrit.wikimedia.org/r/6913
Comment 4 Siebrand Mazeland 2012-05-15 05:53:30 UTC
Reopening because this is not fixed on Wikimedia.
Comment 5 Mark A. Hershberger 2012-05-15 15:45:30 UTC
bumping to highest until it is fixed in prod.
Comment 6 Niklas Laxström 2012-05-15 15:55:25 UTC
I will need help to debug what is the real cause that Revision::getTitle returns null.
Comment 7 Niklas Laxström 2012-05-26 19:04:24 UTC
Initial suspicion is that due to slave lag getTitle returns null because it does another query instead of using/having that information already there.
Comment 8 Niklas Laxström 2012-05-27 18:21:16 UTC
This might have been fixed by https://gerrit.wikimedia.org/r/#/c/9020
Comment 9 Niklas Laxström 2012-05-29 12:55:57 UTC
See also https://gerrit.wikimedia.org/r/#/c/9150/
Comment 10 Niklas Laxström 2012-05-29 12:56:53 UTC
*** Bug 36846 has been marked as a duplicate of this bug. ***
Comment 11 badon 2012-06-02 07:43:14 UTC
In my testing, I observed an identical situation that seemed to be caused by deleting the translations. After the translations were gone, there was no "mark this page for translation" link, even though the translation markup was still present. Making an edit to the page resolved the problem, which seems to match Niklas's guess in comment 1.
Comment 12 badon 2012-06-02 07:46:19 UTC
I found another bit of info in my notes, that I intended to use for my own bug report. Since this bug is already opened, I'll paste it here. After marking a page for translation, this error was reported:

Fatal error: Call to a member function initCollection() on a non-object in /path/to/extensions/Translate/tag/RenderJob.php on line 48

I hope that helps find the bug.
Comment 13 Niklas Laxström 2012-06-14 09:12:43 UTC
(In reply to comment #11)
> In my testing, I observed an identical situation that seemed to be caused by
> deleting the translations. After the translations were gone, there was no "mark
> this page for translation" link, even though the translation markup was still
> present. Making an edit to the page resolved the problem, which seems to match
> Niklas's guess in comment 1.

Please explain what do you mean "deleting the translations".
Comment 14 Niklas Laxström 2012-06-19 09:56:09 UTC
The protection issue has been fixed. Pages no longer appear as "broken" on WMF if protected.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links