Last modified: 2011-12-13 18:13:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35000, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33000 - AntiSpoof: `batchAntiSpoof.php' does not respect `MW_INSTALL_PATH' environment variable.


Summary:	AntiSpoof: `batchAntiSpoof.php' does not respect `MW_INSTALL_PATH' environmen...

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	AntiSpoof (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-reviewed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-12 20:13 UTC by Van de Bugger
Modified:	2011-12-13 18:13 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Proposed patch. (567 bytes, patch) 2011-12-12 20:13 UTC, Van de Bugger	Details
Add an attachment (proposed patch, testcase, etc.)

Description Van de Bugger 2011-12-12 20:13:14 UTC

`extensions/README' says:

> Please note that under POSIX systems (Linux...), parent of a symbolic path
> refers to the link source, NOT to the target! You should check the env
> variable MW_INSTALL_PATH in case the extension is not in the default location.

but `batchAntiSpoof.php' does not respect `MW_INSTALL_PATH' environment variable.

Comment 1 Van de Bugger 2011-12-12 20:13:53 UTC

Created attachment 9666 [details]
Proposed patch.

Comment 2 Daniel Friesen 2011-12-12 20:18:39 UTC

Any reason not to use the 3-liner we use elsewhere:
http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/CheckUser/install.php

Comment 3 Van de Bugger 2011-12-12 20:39:36 UTC

> Any reason not to use the 3-liner we use elsewhere:

Is this question to me? I do not care, if `MW_INSTALL_PATH' environment
variable is respected. My patch is just a combination of existed code and a code snippet from `extensions/README':

> $IP = getenv( 'MW_INSTALL_PATH' );
> if( $IP === false ) {
>     $IP = dirname( __FILE__ ) . '/../..';
> }

It seems for me both variants, '/../..' and `dirname( dirname( ... ) )' work. If you think another variant is more suitable, please go forward.

Comment 4 Mark A. Hershberger 2011-12-13 14:16:25 UTC

r106022

Comment 5 Van de Bugger 2011-12-13 18:13:51 UTC

Verified on r106050.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links