Last modified: 2011-12-13 20:00:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35035, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33035 - Notice: Undefined property: Language::$mHtmlCode in trunk/phase3/languages/Language.php on line 3475


Summary:	Notice: Undefined property: Language::$mHtmlCode in trunk/phase3/languages/La...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Internationalization (Other open bugs)
Version:	1.20.x
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-13 17:14 UTC by Sam Reed (reedy)
Modified:	2011-12-13 20:00 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-12-13 17:14:34 UTC

Notice: Undefined property: Language::$mHtmlCode in /home/reedy/mediawiki/trunk/phase3/languages/Language.php on line 3475

Call Stack:
    0.0021     649568   1. {main}() /home/reedy/mediawiki/trunk/phase3/index.php:0
    0.1465    5516176   2. MediaWiki->run() /home/reedy/mediawiki/trunk/phase3/index.php:58
    0.1466    5516176   3. MediaWiki->main() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:538
    1.5999   52184536   4. MediaWiki->finalCleanup() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:620
    1.6001   52184616   5. OutputPage->output() /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php:407
    1.6114   52638280   6. SkinTemplate->outputPage() /home/reedy/mediawiki/trunk/phase3/includes/OutputPage.php:1975
    1.6176   52658016   7. Language->getHtmlCode() /home/reedy/mediawiki/trunk/phase3/includes/SkinTemplate.php:291


Viewable currently on trunk by visiting any special page.....

Comment 1 Brion Vibber 2011-12-13 19:49:09 UTC

I see this defined as a private attribute already:

	private $mHtmlCode = null;

Seems to have been added in r105925 along with the code using it...? So this shouldn't happen...?

Comment 2 Brion Vibber 2011-12-13 20:00:18 UTC

Per IRC chat w/ Timo this looks like it happens because of the unset() line in Language::setCode(); so if that gets triggered, you end up with the error if getHtmlCode() is called again later.

r106072 should fix this up; replaced the unset() with just setting to null.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links