Last modified: 2012-02-23 00:53:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35045, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33045 - mediawiki.feedback module should not load icon from upload.wikimedia.org
mediawiki.feedback module should not load icon from upload.wikimedia.org
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.18.x
All All
: High blocker (vote)
: 1.18.x release
Assigned To: Brion Vibber
:
Depends on:
Blocks: 34599
  Show dependency tree / graph
 
Reported: 2011-12-13 21:44 UTC by MZMcBride
Modified: 2012-02-23 00:53 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2011-12-13 21:44:35 UTC 
I was testing out <https://www.mediawiki.org/wiki/Special:VisualEditorSandbox> and Google Chrome is throwing a warning:

The page at https://www.mediawiki.org/wiki/Special:VisualEditorSandbox displayed insecure content from http://upload.wikimedia.org/wikipedia/commons/4/42/Loading.gif.

I assume this is simply hard-coded somewhere? I haven't had a chance to look at the code very closely, but this should be a simple fix.
Comment 1 Brion Vibber 2011-12-13 21:45:37 UTC 
This should actually switch to locally hosting the icon, probably.
Comment 2 Trevor Parscal 2011-12-13 22:19:41 UTC 
This icon is not a VisualEditor icon, it's part of the feedback system that the VisualEditorSandbox is using. It may need to be renamed/recategorized.
Comment 3 MZMcBride 2011-12-13 22:57:36 UTC 
(In reply to comment #2)
> This icon is not a VisualEditor icon, it's part of the feedback system that the
> VisualEditorSandbox is using. It may need to be renamed/recategorized.

Eep, sorry about that. You're absolutely right, it's in MediaWiki core. I tracked it down to <http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki/mediawiki.feedback.js?revision=106003&view=markup#l95>.
Comment 4 Krinkle 2012-02-02 19:50:56 UTC 
This should be fixed before 1.19 release and backported if needed. We should not embed WMF resources in any MediaWiki core release.
Comment 5 Brion Vibber 2012-02-23 00:43:26 UTC 
r112169 does a quick protocol-relative switch, but still should be changed to include the actual icon locally.
Comment 6 Brion Vibber 2012-02-23 00:53:56 UTC 
r112172 does a proper fix, turning it into a locally-hosted .gif loaded via styles in the module.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links