Last modified: 2013-08-25 16:22:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35094, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33094 - VisualEditor: Invalid titles for link target are not detected by link editor (e.g. "Foo{}bar" is allowed)
VisualEditor: Invalid titles for link target are not detected by link editor ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-08-15
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-14 11:45 UTC by Liangent
Modified: 2013-08-25 16:22 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2011-12-14 11:45:15 UTC 
Especially those break wikitext.
Comment 1 Helder 2012-06-22 02:21:19 UTC 
From
https://www.mediawiki.org/w/index.php?title=Visual_editor/Feedback&oldid=552919#Links_to_invalid_titles

----
The editor should not allow [//www.mediawiki.org/w/index.php?title=VisualEditor%3ATest&diff=552858&oldid=552851 links to invalid titles].
----
Comment 2 James Forrester 2012-06-22 18:20:12 UTC 
Not sure if new inspector blocks this?
Comment 3 James Forrester 2012-06-22 22:05:43 UTC 
Mass-moving items into VisualEditor product
Comment 4 James Forrester 2012-06-23 01:38:01 UTC 
Mass-move out of "General" to init.
Comment 5 James Forrester 2012-07-02 19:29:26 UTC 
Standardise title.
Comment 6 Krinkle 2012-08-27 18:48:18 UTC 
Looks like a job for mw.Title in core.

It needs better validation. If static validation is not 100% waterproof we could built in a "extra sure" mode in mw.Title that makes an API request.
Comment 7 Rob Moen 2012-09-10 21:38:45 UTC 
Fixed in https://gerrit.wikimedia.org/r/23373 similarly to the way wikiEditor checks for invalid page titles

Would be better handled in mw.Title.
Comment 8 This, that and the other (TTO) 2013-07-09 07:22:57 UTC 
This is back again.
Comment 9 Gerrit Notification Bot 2013-08-01 12:01:14 UTC 
Change 77099 had a related patch set uploaded by Esanders:
Prevent the creation of invalid MWInternalLinks

https://gerrit.wikimedia.org/r/77099
Comment 10 Gerrit Notification Bot 2013-08-14 21:58:29 UTC 
Change 77099 merged by jenkins-bot:
Prevent the creation of invalid MWInternalLinks

https://gerrit.wikimedia.org/r/77099
Comment 11 James Forrester 2013-08-14 21:59:05 UTC 
Fixed again. Sorry, everyone. Will be deployed to MW.org tomorrow, and we'll get it deployed more widely after testing.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links