Last modified: 2013-08-22 23:04:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35112, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 33112 - Gray out undo/redo button if there's nothing to undo/redo


Summary:	Gray out undo/redo button if there's nothing to undo/redo

Status:	RESOLVED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2012-10-15
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-12-14 16:12 UTC by Liangent
Modified:	2013-08-22 23:04 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
This implementation would possibly fix this bug. (2.23 KB, patch) 2011-12-29 18:02 UTC, Ashish Dubey	Details
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2011-12-14 16:12:34 UTC

Comment 1 Mark A. Hershberger 2011-12-22 00:16:22 UTC

please provide more than just a title for bug reports.

Comment 2 Liangent 2011-12-22 02:54:41 UTC

(In reply to comment #1)
> please provide more than just a title for bug reports.

For this report I don't know what to say.

Comment 3 Mark A. Hershberger 2011-12-22 22:07:15 UTC

What undo/redo button are you talking about?

Comment 4 Liangent 2011-12-23 02:19:51 UTC

(In reply to comment #3)
> What undo/redo button are you talking about?

Those in the toolbar added by VisualEditor.

Comment 5 Ashish Dubey 2011-12-29 18:02:12 UTC

Created attachment 9779 [details]
This implementation would possibly fix this bug.

I made tweaks at places which seemed appropriate to me.

1. Added a CSS style, to give disabled buttons a transparent/gray look.
2. And I put some code in the method es.HistoryButtonTool.updateButtons(). At first I created a similar method in es.ToolbarView, but when I found the former already there, I thought it should be the right place to put that code. Though I'm not sure.

Inviting reviews.

Comment 6 Neil Kandalgaonkar 2011-12-31 01:47:09 UTC

Looks okay to me, although it was a bit repetitive so I refactored it a little -- we don't need separate styles for undo or redo buttons, and enabling and disabling them could be more common code. 

This is my first commit to the Visual Editor interface code, so I might have gotten the MVC separation a bit mixed up. Also there's some other code related to disabled buttons so I hope I didn't step on that.

Otherwise, fixed in r107689. 

Thanks, Ashish.

Comment 7 Ashish Dubey 2011-12-31 07:59:36 UTC

Thank you!

Comment 8 James Forrester 2012-10-15 22:57:53 UTC

Mass-moving old VisualEditor tickets to the VE product. Search for this message to mass-delete bugmail.

Comment 9 James Forrester 2012-10-29 18:10:14 UTC

Noting bugs closed in the 2012-10-15 release.

Comment 10 Adam Wight 2013-08-18 08:06:47 UTC

Has regressed, on mediawiki.org at least.

Comment 11 James Forrester 2013-08-19 19:12:52 UTC

(In reply to comment #10)
> Has regressed, on mediawiki.org at least.

Can you give some more detail? Browser/page/action? It seems to work for me in Firefox and Chrome…

Comment 12 James Forrester 2013-08-22 23:04:06 UTC

Re-closing, per discussion with Adam.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links