Last modified: 2014-01-18 16:44:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35168, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33168 - RevisionDeletion-suppress shouldn't claim whole revision for oversighters, only those properties suppressed
RevisionDeletion-suppress shouldn't claim whole revision for oversighters, on...
Status: NEW
Product: MediaWiki
Classification: Unclassified
Revision deletion (Other open bugs)
1.18.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-15 12:29 UTC by Jarry1250
Modified: 2014-01-18 16:44 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jarry1250 2011-12-15 12:29:35 UTC
To quote Franamax on en:WP:VPT:

"One revision had been touched by an oversighter, who suppressed the edit summary but left the version text intact. I was not able to select this version to revision-delete the page text, as the square checkbox was greyed out. This meant that I had to leave material publicly viewable (from the page history) while I waited for further suppression at the oversighter level."

It seems that RevisionDeletion-suppressions "claims" the whole revision for oversighters, when the logical thing to do would be to claim only those properties actually suppressed by the oversighter.
Comment 1 Jarry1250 2011-12-15 13:25:06 UTC
On further prodding this is more difficult than I thought, because we allow admins to select multiple revisions (and hence some with and some without elements of oversight) at the same time. Not to mention the fact that going from Revision-level control to property-level control would be difficult at the best of times. Eurgh.
Comment 2 Allen Stambaugh 2011-12-17 07:35:31 UTC
I think that enwiki uses version 1.18.
Comment 3 Aaron Schulz 2011-12-17 17:28:26 UTC
Any new deletion flag (comment,text) would be oversight level since the suppress flag is set. Since non-oversights can't change that flag, then they can't do anything to the revision without violating permissions.
Comment 4 Jarry1250 2011-12-17 18:42:13 UTC
> I think that enwiki uses version 1.18.

Yes, it displays on 1.18 and 1.19svn, naturally.

> Any new deletion flag (comment,text) would be oversight level since the
> suppress flag is set. Since non-oversights can't change that flag, then they
> can't do anything to the revision without violating permissions

The point is, if the oversighter doesn't change the deletion status of the username/summary/text/etc i.e. leaves it visible, it should be possible for admins to RevDel it. But yes, I agree that the problem with fixing this is that at the moment flags are set per-revision, when really we would need them to be sufficiently granular i.e. be set per property.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links