Last modified: 2014-02-12 23:55:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35189, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33189 - MobileFrontend should not rely on noprint CSS class
MobileFrontend should not rely on noprint CSS class
Status: RESOLVED DUPLICATE of bug 29157
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Nobody - You can work on this!
: mobile
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-16 02:41 UTC by shi zhao
Modified: 2014-02-12 23:55 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description shi zhao 2011-12-16 02:41:24 UTC
Mobile view and printable can't work together, see https://en.wikipedia.org/w/index.php?title=Coat_of_arms_of_Dewsbury&printable=yes&useformat=mobile

".noprint" not work.
Comment 1 MZMcBride 2012-03-03 23:03:04 UTC
Fairly sure this has the same root cause as <https://en.wikipedia.org/w/index.php?title=MediaWiki_talk:Common.css&oldid=480016042#Age_doesn.27t_show_up_on_mobile_wikipedia>. I changed the bug summary to "MobileFrontend should not rely on noprint CSS class" accordingly.

Re-using the "noprint" class is clever, but ultimately unwise. Sometimes you want things to not be on mobile and sometimes you want things to not be on print. They're distinct categories, with some overlap. Luckily, CSS supports multiple classes.

There should be a "nomobile" class that should be used when people want to hide things from mobile. Currently it looks like people are inserting dummy classes to trick the mobile parser (cf. <https://en.wikipedia.org/w/index.php?title=Template:Birth_date_and_age&diff=479816119&oldid=436607844>). This is bad.
Comment 2 MZMcBride 2012-03-03 23:07:00 UTC
Hmmm, and this bug is really a duplicate of bug 29157, isn't it? Hmmm.
Comment 3 Tomasz Finc 2012-03-12 18:44:14 UTC
Yeah, lets simplify our lives and focus on 29157 as its capturing this bugs issues.

*** This bug has been marked as a duplicate of bug 29157 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links