Last modified: 2012-08-07 03:20:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35190, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33190 - WebFonts aren't applied to Fundraising banners
WebFonts aren't applied to Fundraising banners
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
WebFonts (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://or.wikipedia.org/wiki/Main_Pag...
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-16 06:17 UTC by Amir E. Aharoni
Modified: 2012-08-07 03:20 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2011-12-16 06:17:22 UTC
It appears that WebFonts aren't applied to Fundraising banners. Try the URL in Google Chrome - i uninstalled the Lohit Oriya font, and now i see squares there. Firefox successfully loads a fallback font, but Chrome doesn't. Check also font-family in the computed style in the developer tools of your browsers: Lohit Oriya is applied to elements in the body of the page, but not to the banner.
Comment 1 Santhosh Thottingal 2011-12-16 06:27:34 UTC
#B11_Donate_SusanAccept #cn-bold-blue-text {
    color: navy;
    font-family: Helvetica,Arial,sans-serif;
...
}

WebFonts will identify that the text got an already defined font-family style - Helvetica, Arial, sans-serif. And it will not override it.
Comment 2 Brion Vibber 2011-12-16 18:05:45 UTC
Is the proper fix to remove those font-family bits, or to add the expected webfont names into the font-family in the banners?
Comment 3 Amir E. Aharoni 2011-12-16 18:49:21 UTC
If it's possible to remove them, it would probably be the simplest and the most correct thing to. I asked Jon Harald to check whether it's possible to just remove them. Maybe the Fundraising team had a reason to put them in.
Comment 4 Amir E. Aharoni 2011-12-18 10:23:36 UTC
Comment - the bug only shows itself in Chrome if the Lohit Oriya font is not installed locally.
Comment 5 Srikanth Logic 2011-12-28 06:19:16 UTC
Sure this exists now?

I dont have any Oriya font on my Win XP machine and on chrome without WebFonts I see squares everywhere incl banners, but with Lohit-Oriya, am able to see things incl banners (jimmy's one now)
Comment 6 Amir E. Aharoni 2011-12-28 06:22:41 UTC
Srikanth, do you see it in Google Chrome? I still see it.

This is probably not a bug in MediaWiki, but in the design of the banners. Unless there's a good reason to specify "Helvetica,Arial" explicitly, it should be removed.
Comment 7 Srikanth Logic 2011-12-28 06:35:46 UTC
Amir, Sorry for confusion, I think comment 5 was because of a bug 33396 in Chrome.

attachment 9773 [details] shows Banner rendering properly with WebFonts. but comment 5 may not hold water since I have some Oriya font installed on my machine.

Can you also check if there are differences in banners? (The jimmy one and the one you are getting)
Comment 8 Amir E. Aharoni 2011-12-28 06:45:10 UTC
There are many Jimmy banners, but in [1] there is no explicit font-family definition on the #cn-bold-blue-text element and the Oriya fonts appear correctly.

(This banner seems to have a different bug, saying "NaN Cr" instead of the real number of crores; i'll report it.)

[1] http://or.wikipedia.org/wiki/Main_Page?banner=B11_Donate_Projects_ThermoLimited_IN
Comment 9 Santhosh Thottingal 2012-01-12 12:21:32 UTC
Lowering the priority since this issue does not have any immediate impact.
Comment 10 Mark A. Hershberger 2012-01-12 15:49:57 UTC
If this is something that is be a problem in CentralNotice, then
priority should be raised again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links