Last modified: 2012-08-03 00:07:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35191, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33191 - VisualEditor: In add link dialog: the tick button is sometimes still gray even there's text in the box
VisualEditor: In add link dialog: the tick button is sometimes still gray eve...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2012-08-06
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-16 06:41 UTC by Liangent
Modified: 2012-08-03 00:07 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2011-12-16 06:41:34 UTC 
I have to click the textbox after inputting text to make the tick button black and clickable.
Comment 1 Liangent 2011-12-16 06:41:50 UTC 
Browser is Iceweasel.
Comment 2 James Forrester 2012-06-22 20:53:58 UTC 
Believe that this is now fixed with new version of VE (but please re-open if it's still an issue).
Comment 3 Liangent 2012-06-23 05:56:33 UTC 
(In reply to comment #2)
> Believe that this is now fixed with new version of VE (but please re-open if
> it's still an issue).

Still there. Repro:

* Select some text
* Click "Insert link"
* Press backspace key to clear existing text, the button becomes gray
* Input 123 with keyboard now
* The tick is still gray unless I click on the textbox
Comment 4 Rob Moen 2012-07-26 23:05:39 UTC 
Liangent: The text should be focused while inserting text.

Fixed in: Fixed in https://gerrit.wikimedia.org/r/#/c/16529/
Accept button should only disabled if there is no text in the box.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links