Last modified: 2012-10-01 18:49:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35239, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33239 - VisualEditor: Link-activating/following
VisualEditor: Link-activating/following
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High enhancement
: VE-deploy-2012-09-17
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-18 16:41 UTC by Kaseluris-Nikos-1959
Modified: 2012-10-01 18:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kaseluris-Nikos-1959 2011-12-18 16:41:17 UTC
The processes|actions on links we deal-with are:
1) in a browser: a) link activating.
2) in a source-editor: a) link-text editing, b) link-target editing.
3) in a wysiwyg-editor: a) link-text editing, b) link-target editing
c) link activating|following.

In VisualEditor (wysiwyg) link-activation is not yet implemented. So
far I have seen 3 methods for this:
i) double clicking
ii) ctrl + clicking
iii) popup the target, where you can activate the link.

I am using everyday a local hypertext wysiwyg editor for 20 years now
(yes before html!!!) which uses the double-click method. I vote for
this as the fastest and using only one hand.
Comment 1 Ashish Dubey 2012-04-01 10:57:40 UTC
Double click also associates with actions like the word selection, and doing link following on double click might not fit with that well as definitely alot of users while editing would want to use double click to select a word rather than expecting a new window opening the target of that link.
Comment 2 Ashish Dubey 2012-04-01 11:00:15 UTC
Morever, showing the target in a popup on single click over the link might be a good idea.
Comment 3 James Forrester 2012-06-22 20:57:01 UTC
I'd recommend us doing options 2 (ctrl-clicking) and 3 (inspector offers opportunity to follow in new tab); this is behaviour in Google Docs and is a reasonable compromise. :-)
Comment 4 James Forrester 2012-06-22 22:05:24 UTC
Mass-moving items into VisualEditor product
Comment 5 James Forrester 2012-06-23 01:38:38 UTC
Mass-move out of "General" to "ContentEditable".
Comment 6 Brion Vibber 2012-06-23 02:42:48 UTC
Right-click to open context menu followed by 'open in new tab' etc would be the obvious thing, but this doesn't work because the link is actually to '#' instead of to the link target.
Comment 7 James Forrester 2012-06-24 19:15:39 UTC
I think there's some value in over-riding the natural link so that clicking on it (say to edit it) doesn't launch a new window (otherwise the editing experience would suck).
Comment 8 Brion Vibber 2012-06-28 17:39:18 UTC
We can override the behavior via JavaScript while retaining the original href; we do this sort of thing all the time, such as for the "Edit" tab link itself. :)
Comment 9 James Forrester 2012-07-02 19:30:44 UTC
Standardise title.
Comment 10 Trevor Parscal 2012-07-27 23:12:31 UTC
There's 2 things here I want to pick out.

1. Using the actual URL instead of "#" in the rendered HTML so you can right click and say "Open in new tab" or "Copy URL".

2. Adding features to the link dialog, in this case adding a link that will open the link target in a new tab.

To the first point, this is going to happen, the use of # has always been a hack and will go away soon.  Especially since we can't perform copy and paste from JavaScript due to security issues with clipboard access, it's important to us to retain the native menus and selection systems on all devices.

As for the link inspector, we are still experimenting with this design but essentially our use of lightweight inline dialog-like "inspectors" is going to increase over time. The link inspector right now is very primitive, but will soon have the ability to provide suggestions and validation for link targets as you type. We will be adding other things too, such as a link to launch the target in a new tab, as we believe they are needed and they will remain if they can be proven worthy of the screen space in user testing.
Comment 11 Trevor Parscal 2012-09-10 18:52:38 UTC
Resolved with I1a1cfd70c222dd1d686b46cd702edf2e9d0e5bae

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links