Last modified: 2013-10-23 18:16:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35246, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33246 - News icon shown for news:// should also apply to news: URLs
News icon shown for news:// should also apply to news: URLs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.18.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-19 00:15 UTC by Gadget850
Modified: 2013-10-23 18:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch for vector/screen.css (452 bytes, patch)
2011-12-19 12:24 UTC, Erwin Dokter 		Details
Patch for vectror/screen.css (452 bytes, patch)
2011-12-19 12:33 UTC, Erwin Dokter 		Details
Patch for monobook/main.css (436 bytes, patch)
2011-12-19 12:33 UTC, Erwin Dokter 		Details
Patch for modern/main.css (413 bytes, patch)
2011-12-19 12:34 UTC, Erwin Dokter 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Gadget850 2011-12-19 00:15:12 UTC 
The main CSS has rules for external link icons based on recognizing URI schemes. For example, the http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=ext.wikihiero%7Cmediawiki.legacy.commonPrint%2Cshared%7Cskins.vector&only=styles&skin=vector&* main Vector CSS has a rule for news:// so that it creates a link and an icon.

As I see it, per RfC 5538, the URI scheme can be either news:// or news:but the latter is not supported by the CSS. Looks to me like the CSS should be updated to support news: which would support both schemes.
Comment 1 Erwin Dokter 2011-12-19 12:24:03 UTC 
Created attachment 9739 [details]
Patch for vector/screen.css

Changed CSS selector from "news://" to "news:".
Comment 2 Erwin Dokter 2011-12-19 12:33:14 UTC 
Created attachment 9740 [details]
Patch for vectror/screen.css
Comment 3 Erwin Dokter 2011-12-19 12:33:49 UTC 
Created attachment 9741 [details]
Patch for monobook/main.css
Comment 4 Erwin Dokter 2011-12-19 12:34:38 UTC 
Created attachment 9742 [details]
Patch for modern/main.css
Comment 5 Roan Kattouw 2011-12-21 18:59:22 UTC 
Applied in r106964.
Comment 6 Gadget850 2012-03-01 12:00:18 UTC 
Confirmed working on en.wp.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links