Last modified: 2011-12-29 15:40:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35252, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33252 - WikimediaMaintenance maintenance scripts include Maintenance.php from the wrong place
WikimediaMaintenance maintenance scripts include Maintenance.php from the wro...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikimediaMaintenance (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-19 14:44 UTC by Roan Kattouw
Modified: 2011-12-29 15:40 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2011-12-19 14:44:10 UTC 
WMF-specific maintenance scripts have been moved to extensions/WikimediaMaintenance/ in trunk but still live in maintenance/ in 1.18wmf1. I'm assuming these will move on the cluster as well when 1.19 is deployed, but as it stands that will break horribly.

The way the scripts includes Maintenance.php still assumes they are directly in the maintenance/ directory (or a subdirectory thereof). Some are so old they include commandLine.inc instead, sometimes even without an absolute path. Also, only one script respects MW_INSTALL_PATH.

It looks like WikimediaMaintenance.php is an appropriate bootstrap script that these scripts should be including instead. It also includes an abstract Maintenance subclass that new scripts should probably use, like dumpInterwiki.php does.

Should the other scripts just be ported to use WikimediaMaintenance.php then?
Comment 1 Chad H. 2011-12-19 14:45:18 UTC 
(In reply to comment #0)
> Should the other scripts just be ported to use WikimediaMaintenance.php then?

Yes.
Comment 2 Sam Reed (reedy) 2011-12-29 15:40:39 UTC 
r107575, r107576, r107577
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links