Last modified: 2012-10-15 22:57:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35267, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33267 - ACCEL+K should NOT activate the Link Window
ACCEL+K should NOT activate the Link Window
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-20 05:13 UTC by Brandon Harris
Modified: 2012-10-15 22:57 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brandon Harris 2011-12-20 05:13:58 UTC
Currently, hitting <control> or <command> + K in the Visual Editor opens a link dialog.  This is sub-optimal, as <control>-k is (and has been, for about 30 years) the "kill" command in emacs-like editors.  (<ctrl>-k adds to the kill ring, <ctrl>-y pastes the kill ring into the contents).  

I suggest that the Visual Editor should support these basic commands by default, without modification via preferences (e.g., "use emacs keybindings").  Activation of the link editor should probably be moved to a more intuitive accelerator anyways ("k" does not suggest "link" to me).

For implementation, the "kill ring" functionality operates thus:  <ctrl>-k deletes the current line of text, including the EOL character. This text is copied into the "kill ring" buffer.  Additional <ctrl>-k expressions ''add'' to the kill ring; ''any'' other activity (including cursor movement) "closes" the kill ring.  At that point, <ctrl>-y will insert the entire contents of the kill ring into the text at the point of the cursor.
Comment 1 Trevor Parscal 2011-12-21 00:01:23 UTC
Common rich-text editors like Google Docs and Microsoft Word. Emacs keybindings should not and will not be inherited or maneuvered around.
Comment 2 Trevor Parscal 2011-12-21 00:02:16 UTC
Sorry  if that last post was incoherent - I meant to say "Common rich-text editors like Google Docs and Microsoft Word all use command+K for hyperlinks"
Comment 3 Brandon Harris 2011-12-21 00:43:01 UTC
That's actually a pretty good reason, though I don't necessarily think we should look to either of those applications for overall design cues.

I'm going to close this.
Comment 4 James Forrester 2012-10-15 22:57:20 UTC
Mass-moving old VisualEditor tickets to the VE product. Search for this message to mass-delete bugmail.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links