Last modified: 2011-12-29 14:57:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35282, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33282 - "Confirm block" checkbox for self-blocks is hard to find
"Confirm block" checkbox for self-blocks is hard to find
Status: NEW
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-20 19:53 UTC by Brion Vibber
Modified: 2011-12-29 14:57 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Annotated screenshot (61.86 KB, image/png)
2011-12-20 19:53 UTC, Brion Vibber
Details

Description Brion Vibber 2011-12-20 19:53:28 UTC
Created attachment 9752 [details]
Annotated screenshot

Special:Block has a "confirm block" checkbox in some circumstances (at least when blocking yourself). This is small and non-obvious at the bottom of a pile of other checkboxes that you usually don't have to push, and is very far away from the big red warning that "You are about to block yourself! Are you sure you want to do that!"

Initially I couldn't tell that I was supposed to check a box and thought I just had to click "Block this user" a second time; after a few times through that I found the checkbox.

Recommendation:
* replace the checkbox with a button
or
* put the checkbox next to the warning
Comment 1 Krinkle 2011-12-29 10:48:20 UTC
Other ideas:

1)
* Remove post-submit "error" and checkbox
* Normal submit
* After submit go to confirmation screen (could be AJAXified to not need a refresh)

2)
* Remove post-submit "error" and checkbox
* Extend existing JavaScript module to disable the submit button when username matches logged-in user, and add a checkbox next to the submit button "[_] Are you sure you want to block yourself ?"
Comment 2 Krinkle 2011-12-29 10:48:58 UTC
2) ..which when ticked would set input.disabled=false
Comment 3 Bawolff (Brian Wolff) 2011-12-29 10:59:34 UTC
Be nice if whatever solution is chosen could be worked into HTMLForm in some sort of generic way.
Comment 4 Happy-melon 2011-12-29 14:57:02 UTC
(In reply to comment #1)

> Other ideas:
> 
> 1)
> * Remove post-submit "error" and checkbox
> * Normal submit
> * After submit go to confirmation screen (could be AJAXified to not need a
> refresh)

That's exactly what the current system is; it's just that confirmation screen looks almost exactly the same as the original screen :)
 
> 2)
> * Remove post-submit "error" and checkbox
> * Extend existing JavaScript module to disable the submit button when username
> matches logged-in user, and 

So now only admins without javascript can accidentally block themselves?  :p  

This would certainly work as a JS 'graceful enable' to replace the (inevitably more clunky) web1.0 version.

> 2) add a checkbox next to the submit button "[_] Are
> you sure you want to block yourself ?" ..which when ticked would set input.disabled=false

It doesn't need to be a checkbox, just a popup confirm/cancel intercepting the form submission.

(In reply to comment #3)
> Be nice if whatever solution is chosen could be worked into HTMLForm in some
> sort of generic way.

It would be something like $('#somewrapperid input.mw-htmlform-submit').click(interceptFunction) rather than anything particular to HTMLForm.  It's already pretty generic, but if you wanted to make it more so, you'd be making jquery plugins for HTMLForms.  Mind you, we need to revamp our JS integration with HTMLForm all round, so this might be a good thing to do in that.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links