Last modified: 2014-02-18 22:38:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35284, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33284 - Make mwscript.php also look in WikimediaMaintenance
Make mwscript.php also look in WikimediaMaintenance
Status: REOPENED
Product: Wikimedia
Classification: Unclassified
Deployment systems (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: platformeng
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-20 21:55 UTC by Sam Reed (reedy)
Modified: 2014-02-18 22:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch! (3.00 KB, patch)
2012-01-20 01:39 UTC, Sam Reed (reedy)
Details

Description Sam Reed (reedy) 2011-12-20 21:55:40 UTC
It'd be useful if mwscipt looked in /extensions/WikimediaMaintenance aswell as /maintenance when trying to run maintenance script so people don't have to go looking for where scripts might be hiding

ie if script is not in /maintenance try /extensions/WikimediaMaintenance

Thanks!
Comment 1 Sam Reed (reedy) 2011-12-20 22:02:03 UTC
<AaronSchulz> Reedy: /trunk/tools/mwmultiversion/multiversion/MWScript.php
Comment 2 Aaron Schulz 2012-01-20 00:04:51 UTC
This will actually require a moderate amount of refactoring. You need to be able to get the MW version without knowing the file path yet. The current getMediaWikiCli() functions is not very amenable to this. Also, you'd have to do it a non-circular way. For example, locating the file path depends on getting the MW version if you want to use file_exists() checks, which depends on the --wiki param, which depends on the $wikiLess script list and the file path. Of course, you are trying to *get* the file path. $wikiLess scripts should just be assumed to exists I guess.
Comment 3 Sam Reed (reedy) 2012-01-20 01:39:05 UTC
Created attachment 9874 [details]
Patch!
Comment 4 Sam Reed (reedy) 2012-01-22 01:00:41 UTC
r109711
Comment 5 Sam Reed (reedy) 2012-01-23 15:06:59 UTC
Reverted in r109825
Comment 6 Andre Klapper 2013-03-18 15:41:52 UTC
Reedy: Do you plan to work on this? 
If not, could you please reassign this to default (nobody@)?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links