Last modified: 2012-08-12 10:17:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35330, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 33330 - only full legal code is linked in the settings
only full legal code is linked in the settings
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-22 19:30 UTC by Saibo
Modified: 2012-08-12 10:17 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Saibo 2011-12-22 19:30:25 UTC
e.g. "Own work - Creative Commons Attribution ShareAlike 3.0 (legal code)" links only to http://creativecommons.org/licenses/by-sa/3.0/legalcode which is not very helpful to most users. Instead or in addition the translated deed should be linked!
Comment 2 Maarten Dammers 2011-12-22 19:42:27 UTC
Drop the full deed link and make the relevant text link to the deed in the right language.
Comment 3 Saibo 2011-12-23 20:22:42 UTC
(In reply to comment #2)
> Drop the full deed link and make the relevant text link to the deed in the
> right language.
Do you mean the full legal code link?
Comment 4 Saibo 2011-12-24 01:59:33 UTC
btw: idea: to not mess around with non-available deed languages at Creative Commons instead link to the Commons templates. Or directly show them rendered in a popup (but replace all link with target=new in html).
Comment 5 Neil Kandalgaonkar 2011-12-24 03:55:26 UTC
For what it's worth, I think there is some question about what the correct URL is. I've been working with the lawyers here at the WMF and they are trying to protect us in the best way they know how.

The choice to link to the legalese version of the code was deliberate, for legal reasons. Although I agree it is bad to have a prominent link to something that's not very helpful.

Let me get some feedback on this from our legal team. This will take a while since we just went into the winter holidays.

Would it be bad if we had two links -- one to the human-readable code, the other to the legal code?
Comment 6 Maarten Dammers 2011-12-24 17:49:03 UTC
Yes, I meant to get rid of http://creativecommons.org/licenses/by-sa/3.0/legalcode and start using http://creativecommons.org/licenses/by-sa/3.0/deed.en

We never link to full legal code, I don't think it's useful to start doing it here. 

On a technical note. We're getting more and more locations where we localize Creative Commons messages:
* The license extension used for the templates
* Upload wizard itself
* This configuration option

Would probably best to consolidate these translation messages.
Comment 7 Saibo 2011-12-24 23:17:21 UTC
(In reply to comment #5)
> The choice to link to the legalese version of the code was deliberate, for
> legal reasons. Although I agree it is bad to have a prominent link to something
> that's not very helpful.
Our license templates (e.g. [[commons:Template:Cc-by-sa-3.0]]) link to the deed only which links to the legal code. In fact I think our license templates should also directly link to the legal code (which is what is -probably- relevant in the end) like we've done it after the last cc license template redesign at dewp: e.g. [[:de:Vorlage:Bild-CC-by-sa/3.0]]. There we decided that we only link to the legal code and emphasize directly in the license template that this is the legally binding stuff. Instead we did not link to the deed as it is more or less the same as our license template. 
In order to be consistent and to avoid several places of config I had proposed above that you link to our license templates at commons instead - so you have diverted the task to them. And actually - those templates are that what is on the file page after uploader. That is what the uploader should see before upload because it will be there after upload and we want to make sure that he made a thoughtful decision by placing THIS template an the file.
Comment 8 Maarten Dammers 2011-12-24 23:40:49 UTC
I strongly disagree with linking to the full legal code. 

It's not required: The Creative Commons licenses require linking to the URI. This is implemented by linking to the base url (http://creativecommons.org/licenses/by/3.0/), not the full legal code. Go check out all the nice wizards at http://creativecommons.org/ to see how Creative Commons recommends people to do this.

It's not user friendly at all: The legal code is unreadable compared to the deed. The legal code is only available in one language, the deed is available in several languages.
Comment 9 Saibo 2011-12-25 22:52:01 UTC
(In reply to comment #8)
> I strongly disagree with linking to the full legal code. 
With whom do you disagree strongly? ;-)
Comment 10 Neil Kandalgaonkar 2011-12-27 19:17:21 UTC
I'm forwarding the relevant bits of the discussion here to WMF legal team for their advice. They wanted the link to the legalese version because it protects us the best. But I agree it has significant usability issues.
Comment 11 Neil Kandalgaonkar 2011-12-28 01:43:17 UTC
Ok, it seems the lawyers are fine with linking to the CC human readable stuffs. Fixed in r107462. URLs verified to exist.
Comment 12 Saibo 2011-12-29 00:33:13 UTC
http://creativecommons.org/licenses/by-sa/3.0/ is english for me - it should instead be in German for me. That is why I said: link to our templates...
Comment 13 Saibo 2011-12-29 00:34:53 UTC
(In reply to comment #12)
> http://creativecommons.org/licenses/by-sa/3.0/ is english for me - it should
> instead be in German for me. That is why I said: link to our templates...

Or you can link to the translated deed (see the footer of each deed page). 

Think of this: [[:commons:Commons_talk:Upload_Wizard#Upload_wizard_-_community_hackers_edition]]  Just a reminder..
Comment 14 Neil Kandalgaonkar 2011-12-29 00:43:17 UTC
I'm not sure that our translations have the same legal force. The whole point of these links isn't usability (sadly) but being legally correct.

If we link to our templates, then it's two hops away from the "real" legal code.

The Creative Commons site does offer translations in some languages, but then it gets complicated to track those.

But I'll pass your comments onwards.
Comment 15 Erik Moeller 2011-12-29 00:56:04 UTC
From both a legal _and_ usability point of view, the current templates aren't ideal, because 1) they don't include the full text of the human-readable deed (i.e. the "With the understanding that.." portion), 2) they are, as Neil says, two clicks away from the legal code. 

The templates could be changed to link to the legal code (and that's a change you'd be well-positioned to make, Saibo, and it would be a good one), but even if they are, the templates are likely always going to be an abbreviated version of the full deed.

For the purposes of choosing a license, linking at least to the full, official deed which in turn always links to the full (English-only) legal code seems like the most sensible option.

The actual license names already have i18n messages, so how about adding a <messagekey>-url message for each license URL? Then translations of the deeds could be localized as appropriate, and would default to English if no localized version is available.
Comment 16 Saibo 2011-12-30 23:18:20 UTC
(In reply to comment #15)
> The templates could be changed to link to the legal code (and that's a change
> you'd be well-positioned to make, Saibo, and it would be a good one), but even
> if they are, the templates are likely always going to be an abbreviated version
> of the full deed.
I will not change the templates - too busy with rotating images... you know - the other WMF fuck-up ;)  

(In reply to comment #15) 
> The actual license names already have i18n messages, so how about adding a
> <messagekey>-url message for each license URL? Then translations of the deeds
> could be localized as appropriate, and would default to English if no localized
> version is available.
I do not know how the off-wiki translatewiki stuff works - a link to our template  (or show it in a overlay-popup) would be easier... Do it the complicated way if you like. ;)
Comment 17 Mark A. Hershberger 2011-12-31 00:56:33 UTC
Adding the TranslateWiki people to see what their input on the translations.
Comment 18 Siebrand Mazeland 2011-12-31 09:20:51 UTC
Thanks Mark. Maarten Dammers is very qualified here, so he'll represent most of the views we would have.
Comment 19 Rob Lanphier 2012-01-23 23:02:03 UTC
Bumping down priority since core issue was addressed.
Comment 20 Saibo 2012-01-24 22:05:56 UTC
(In reply to comment #19)
> core issue was addressed.

What was changed? Nothing, AFAIK. It is http://creativecommons.org/licenses/by-sa/3.0/legalcode at http://commons.wikimedia.org/w/index.php?title=Special:Preferences&uselang=de#mw-prefsection-uploads
Comment 21 Mark Holmquist 2012-05-29 17:41:18 UTC
Saibo, I get the link to the deed at that page, and at every other page in the tool. Is there any other part of this bug that hasn't been addressed, or can we close it? It seems like linking to the deed instead of the full legal code was the entire point, and we've done that.

Are the i18n people interested in changing the links to the localized ones? We could probably just add that in by using 'deed.' plus the language code, since if the page doesn't exist on the CC site it just redirects to 'deed.en' (the English version), which makes sense. Any objections to that?
Comment 22 Saibo 2012-06-02 23:43:37 UTC
Thanks, looks fixed (checked the prefs page) to me.(In reply to comment #21)

(In reply to comment #21)
> Are the i18n people interested in changing the links to the localized ones? We
> could probably just add that in by using 'deed.' plus the language code, since
> if the page doesn't exist on the CC site it just redirects to 'deed.en' (the
> English version), which makes sense. Any objections to that?

That would be very useful. (like I said in the initial comment "the translated deed should be linked").
Comment 23 Mark Holmquist 2012-06-11 17:43:15 UTC
Saibo, thanks for the idea. Patch here: https://gerrit.wikimedia.org/r/10955

It appears to work pretty well--'qqx' forwards back to 'en', 'en_GB' appears to have its own separate page, 'de' properly links to the German page and 'de_qq' links back to 'de' because 'qq' is not an acceptable subset of 'de'. Very good stuff, hopefully this helps with i18n of the licenses.
Comment 24 Saibo 2012-06-11 23:51:04 UTC
Looks good, thanks!

The following seems to be /not/ an issue here since everything gets properly escaped/passed by jquery.. but, in general, one has to be careful with the language code:

Opening  
> https://commons.wikimedia.org/w/index.php?title=Special:Preferences&uselang=%22%20%6f%6e%6d%6f%75%73%65%6f%76%65%72%3D%22%61%6c%65%72%74%28%27%79%6f%75%20%68%61%76%65%20%62%65%65%6e%20%78%73%73%65%64%21%27%29%22#mw-prefsection-uploads

and running 
> alert(mw.config.get( 'wgUserLanguage' ));
returns 
" onmouseover="alert('you have been xssed!')

If that language code gets embedded into to some link ...
Comment 25 Thehelpfulone 2012-06-22 19:41:09 UTC
Reassigning to wikibugs-l per bug 37789
Comment 26 matanya 2012-08-12 10:17:42 UTC
Patch merged, seems to solve the issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links